You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/11/02 08:44:00 UTC
[jira] [Commented] (AVRO-2944) DataFileReader has incorrect logic
reading magic header
[ https://issues.apache.org/jira/browse/AVRO-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17224498#comment-17224498 ]
ASF subversion and git services commented on AVRO-2944:
-------------------------------------------------------
Commit 942ec8e0cc011ec9fcfff7ba9f5c656bb54d51d1 in avro's branch refs/heads/master from Mick Jermsurawong
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=942ec8e ]
AVRO-2944: Fix read pointer in java reader to avoid hang on partial read input stream (#969)
* Add regression test to show failure before fixing
format test
* Fix: increment counter with number of bytes read
> DataFileReader has incorrect logic reading magic header
> -------------------------------------------------------
>
> Key: AVRO-2944
> URL: https://issues.apache.org/jira/browse/AVRO-2944
> Project: Apache Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.9.2
> Reporter: Mick Jermsurawong
> Assignee: Mick Jermsurawong
> Priority: Major
> Fix For: 1.10.1
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> When creating reader using static method which includes checking for magic header, we currently read 4 bytes but the pointer is not correctly updated.
> [https://github.com/apache/avro/blob/328c539afc77da347ec52be1e112a6a7c371143b/lang/java/avro/src/main/java/org/apache/avro/file/DataFileReader.java#L61-L62]
> When inputstream reads less byte than expected, this will get stuck in the loop until the end of file. Or if inputstream returns -1, for EOF like S3AInpustream, read hangs in this loop.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)