[GitHub] [incubator-shardingsphere] cherrylzhao edited a comment on issue #3732: when max.connections.size.per.query is greater than 1, uncommitted records may not been visiable when we execute query SQL in current transaction.

[GitBox <gi...@apache.org>]

cherrylzhao edited a comment on issue #3732: when max.connections.size.per.query is greater than 1, uncommitted records may not been visiable when we execute query SQL in current transaction.
URL: https://github.com/apache/incubator-shardingsphere/issues/3732#issuecomment-565890682
 
 
   I have reproduce this problem in my local machine. when `max.connections.size.per.query` is greater than 1, uncommitted records may not been visiable when we execute query SQL in current transaction. the reason is that insert SQL will only cached one uncommitted connection in cache, but query SQL will get other connections which would not seen the transaction context. so we should add constraint in getting connection logic, when we start a transaction we should only get cached connections `max.connections.size.per.query` should be ignored here. also see #3015 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services