You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Ryota Egashira <eg...@yahoo-inc.com> on 2014/01/09 19:25:08 UTC
Re: Review Request 15893: [OOZIE-1629] EL function in is not
evaluated properly
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15893/
-----------------------------------------------------------
(Updated Jan. 9, 2014, 6:25 p.m.)
Review request for oozie.
Bugs: OOZIE-1629
https://issues.apache.org/jira/browse/OOZIE-1629
Repository: oozie
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1629
Diffs
-----
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionMaterializeCommand.java 1546245
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 1546245
trunk/core/src/main/resources/oozie-default.xml 1546245
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java 1546245
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java 1546245
Diff: https://reviews.apache.org/r/15893/diff/
Testing (updated)
-------
ran coord jobs on local cluster and tested
Thanks,
Ryota Egashira
Re: Review Request 15893: [OOZIE-1629] EL function in is not
evaluated properly
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
> On Jan. 9, 2014, 10:19 p.m., Mona Chitnis wrote:
> > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionMaterializeCommand.java, line 270
> > <https://reviews.apache.org/r/15893/diff/3/?file=394868#file394868line270>
> >
> > what can be time-unit here if this method is specifically for minutes? is this being handled?
tu.getCalendarUnit() returns timeunit corresponding to EL function specified in workflow (if coord:days-->day), minute as default.
but whatever unit specified, diff will be converted to minute in the end.
- Ryota
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15893/#review31471
-----------------------------------------------------------
On Jan. 9, 2014, 6:25 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15893/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2014, 6:25 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1629
> https://issues.apache.org/jira/browse/OOZIE-1629
>
>
> Repository: oozie
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1629
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionMaterializeCommand.java 1546245
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 1546245
> trunk/core/src/main/resources/oozie-default.xml 1546245
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java 1546245
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java 1546245
>
> Diff: https://reviews.apache.org/r/15893/diff/
>
>
> Testing
> -------
>
> ran coord jobs on local cluster and tested
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request 15893: [OOZIE-1629] EL function in is not
evaluated properly
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15893/#review31471
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionMaterializeCommand.java
<https://reviews.apache.org/r/15893/#comment59967>
what can be time-unit here if this method is specifically for minutes? is this being handled?
- Mona Chitnis
On Jan. 9, 2014, 6:25 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15893/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2014, 6:25 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1629
> https://issues.apache.org/jira/browse/OOZIE-1629
>
>
> Repository: oozie
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1629
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionMaterializeCommand.java 1546245
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 1546245
> trunk/core/src/main/resources/oozie-default.xml 1546245
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java 1546245
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java 1546245
>
> Diff: https://reviews.apache.org/r/15893/diff/
>
>
> Testing
> -------
>
> ran coord jobs on local cluster and tested
>
>
> Thanks,
>
> Ryota Egashira
>
>