[GitHub] [incubator-superset] 1AB9502 opened a new pull request #7638: Add new escape characters to OnPasteSelect

[GitBox <gi...@apache.org>]

1AB9502 opened a new pull request #7638: Add new escape characters to OnPasteSelect
URL: https://github.com/apache/incubator-superset/pull/7638
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Our internal users love pasting stuff info filters from CSVs or excel docs.
   Currently onPasteSelect only parses comma separated values. I added new line and tabs (you never know) to the separator array
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   In order to test the implementation I pasted the following values into the filter sections in the charts
   regression test:
   12345,45678,78906
   
   new values tests
   12345,
   45678,
   78906
   
   12345
   45678
   78906
   
   All values got parsed correctly 
   
   # ADDITIONAL INFO
   Duplicates closed pull request #7634 since I fudged something up in my local repo

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org