You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/09/25 15:19:37 UTC
[GitHub] [pulsar-helm-chart] pinkavaj opened a new pull request #69: Allow use of existing secret for pulsar manager credentials
pinkavaj opened a new pull request #69:
URL: https://github.com/apache/pulsar-helm-chart/pull/69
### Motivation
This allows store secrets out of the configuration file and manage them with external tools to keem them actualy secret.
### Modifications
Create the pulsar manager secret only conditionaly.
### Verifying this change
Tested on my own deployment.
- [ ] Make sure that the change passes the CI checks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] pinkavaj commented on pull request #69: Allow use of existing secret for pulsar manager credentials
Posted by GitBox <gi...@apache.org>.
pinkavaj commented on pull request #69:
URL: https://github.com/apache/pulsar-helm-chart/pull/69#issuecomment-713175853
> @pinkavaj Seems there are some ci failure, would you please help take a look?
I would like to, but it looks like this is some CI issue `Error: Kubernetes cluster unreachable`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] pinkavaj commented on a change in pull request #69: Allow use of existing secret for pulsar manager credentials
Posted by GitBox <gi...@apache.org>.
pinkavaj commented on a change in pull request #69:
URL: https://github.com/apache/pulsar-helm-chart/pull/69#discussion_r541904745
##########
File path: charts/pulsar/values.yaml
##########
@@ -963,6 +963,8 @@ pulsar_manager:
hostname: ""
path: "/"
+ ## If set use existing secret with specified name to set pulsar admin credentials.
+ existingSecret:
Review comment:
Updated. It was my opinio the original name is the most used for this purpose and thus best fit into the helm charts ecosystem, but this of course might be only mi bias, sinc I does not have any strong support for this..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] sijie commented on pull request #69: Allow use of existing secret for pulsar manager credentials
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #69:
URL: https://github.com/apache/pulsar-helm-chart/pull/69#issuecomment-713847982
@jiazhai the CI is failing due to apache/pulsar-helm-chart#76
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] jiazhai commented on pull request #69: Allow use of existing secret for pulsar manager credentials
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #69:
URL: https://github.com/apache/pulsar-helm-chart/pull/69#issuecomment-709089912
@pinkavaj Seems there are some ci failure, would you please help take a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] sijie commented on a change in pull request #69: Allow use of existing secret for pulsar manager credentials
Posted by GitBox <gi...@apache.org>.
sijie commented on a change in pull request #69:
URL: https://github.com/apache/pulsar-helm-chart/pull/69#discussion_r541144148
##########
File path: charts/pulsar/values.yaml
##########
@@ -963,6 +963,8 @@ pulsar_manager:
hostname: ""
path: "/"
+ ## If set use existing secret with specified name to set pulsar admin credentials.
+ existingSecret:
Review comment:
Can you name it as `existingSecretName`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] sijie merged pull request #69: Allow use of existing secret for pulsar manager credentials
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #69:
URL: https://github.com/apache/pulsar-helm-chart/pull/69
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] sijie commented on pull request #69: Allow use of existing secret for pulsar manager credentials
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #69:
URL: https://github.com/apache/pulsar-helm-chart/pull/69#issuecomment-726488182
@pinkavaj Can you rebase your pull request to the latest master?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org