You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@linkis.apache.org by GitBox <gi...@apache.org> on 2021/12/08 12:09:33 UTC
[GitHub] [incubator-linkis] legendtkl opened a new pull request #1173: check the task code and make sure it's not empty
legendtkl opened a new pull request #1173:
URL: https://github.com/apache/incubator-linkis/pull/1173
fix https://github.com/apache/incubator-linkis/issues/1143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org
[GitHub] [incubator-linkis] peacewong commented on a change in pull request #1173: check the task code and make sure it's not empty
Posted by GitBox <gi...@apache.org>.
peacewong commented on a change in pull request #1173:
URL: https://github.com/apache/incubator-linkis/pull/1173#discussion_r765765167
##########
File path: linkis-computation-governance/linkis-engineconn/linkis-computation-engineconn/src/main/scala/org/apache/linkis/engineconn/computation/executor/execute/ComputationExecutor.scala
##########
@@ -145,6 +145,11 @@ abstract class ComputationExecutor(val outputPrintLimit: Int = 1000) extends Acc
def toExecuteTask(engineConnTask: EngineConnTask, internalExecute: Boolean = false): ExecuteResponse = {
+ if (engineConnTask.getCode.trim.isEmpty) {
+ error(s"The code must not be empty!")
+ return ErrorExecuteResponse("The code must not be empty!", null)
Review comment:
Hello, here to consider the case of submitting comment code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org