[jira] [Commented] (TS-1839) make check fails without prior make install

["Leif Hedstrom (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13643448#comment-13643448 ] 

Leif Hedstrom commented on TS-1839:
-----------------------------------

This is becuase of this in Layout:
{code}
     if (access(path, R_OK) == -1) {
      ink_error("unable to access() TS_ROOT '%s': %d, %s\n", path, errno, strerror(errno));
      return;
     }
{code}


I'm not sure how to best resolve this, honestly it might make most sense to let this continue with an ink_warning(), and then let application(s) (like traffic_server) who really need the install root to fail later.

E.g.
{code}
     if (access(path, R_OK) == -1) {
-      ink_error("unable to access() TS_ROOT '%s': %d, %s\n", path, errno, strerror(errno));
-      return;
+      ink_warning("unable to access() TS_ROOT '%s': %d, %s\n", path, errno, strerror(errno));
     }
{code}

                
> make check fails without prior make install
> -------------------------------------------
>
>                 Key: TS-1839
>                 URL: https://issues.apache.org/jira/browse/TS-1839
>             Project: Traffic Server
>          Issue Type: Bug
>            Reporter: Igor Galić
>
> make[2]: Entering directory `/home/igalic/src/asf/trafficserver/proxy'
> make  check-TESTS
> make[3]: Entering directory `/home/igalic/src/asf/trafficserver/proxy'
> ERROR: unable to access() TS_ROOT '/opt/ats-trunk': 2, No such file or directory
> FAIL: tests/test_logstats_json
> ERROR: unable to access() TS_ROOT '/opt/ats-trunk': 2, No such file or directory
> ./tests/test_logstats_summary: line 23:  9060 Segmentation fault      (core dumped) ./traffic_logstats --log_file "$srcdir/tests/logstats.blog" --summary > "$tmpfile"
> FAIL: tests/test_logstats_summary
> =============================================
> 2 of 2 tests failed
> Please report to dev@trafficserver.apache.org
> =============================================
> Backtrace: {noformat}Program terminated with signal 11, Segmentation fault.
> #0  ink_strlcpy (dst=<optimized out>, src=0x0, siz=<optimized out>) at ink_string.cc:259
> 259           if ((*d++ = *s++) == '\0')
> (gdb) bt
> #0  ink_strlcpy (dst=<optimized out>, src=0x0, siz=<optimized out>) at ink_string.cc:259
> #1  0x000000000041de58 in main (argv=0x7fff92e8bf58) at logstats.cc:2269
> (gdb) 
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira