You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "Nicolas Malin (Jira)" <ji...@apache.org> on 2021/06/29 08:28:00 UTC
[jira] [Updated] (OFBIZ-12268) Improve js function
OfbizUtil.ajaxSubmitFormUpdateAreas
[ https://issues.apache.org/jira/browse/OFBIZ-12268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Malin updated OFBIZ-12268:
----------------------------------
Description:
At this time the function ajaxSubmitFormUpdateAreas present on themes/common-theme/webapp/common/js/util/OfbizUtil.js take a form, submit it thought ajax and wait a success to analyse a json result for update an area with the cvsAreaString given on paramater.
I propose different imrpovements :
* refactoring some js code to centralize the analyze of json result for check if the call is a success or error
* Analyze the content-type of the response if is a json continue as before, else take the return and update first area (useful for submit search or filtering form)
* Manage the case who the ajax call failed and we inform the user
* Add a trigger to force the modal close on submit success
was:
At this time the function ajaxSubmitFormUpdateAreas present on themes/common-theme/webapp/common/js/util/OfbizUtil.js take a form, submit it thought ajax and wait a success to analyse a json result for update an area with the cvsAreaString given on paramater.
I propose different imrpovement :
* refactoring some js code to centralize the analyze of json result for check if the call is a success or error
* Analyze the content-type of the response if is a json continue as before, else take the return and update first area (useful for submit search or filtering form)
* Manage the case who the ajax call failed and we inform the user
> Improve js function OfbizUtil.ajaxSubmitFormUpdateAreas
> -------------------------------------------------------
>
> Key: OFBIZ-12268
> URL: https://issues.apache.org/jira/browse/OFBIZ-12268
> Project: OFBiz
> Issue Type: Sub-task
> Components: themes
> Affects Versions: Trunk
> Reporter: Nicolas Malin
> Assignee: Nicolas Malin
> Priority: Minor
> Labels: ajax, js, screen, theme
>
> At this time the function ajaxSubmitFormUpdateAreas present on themes/common-theme/webapp/common/js/util/OfbizUtil.js take a form, submit it thought ajax and wait a success to analyse a json result for update an area with the cvsAreaString given on paramater.
> I propose different imrpovements :
> * refactoring some js code to centralize the analyze of json result for check if the call is a success or error
> * Analyze the content-type of the response if is a json continue as before, else take the return and update first area (useful for submit search or filtering form)
> * Manage the case who the ajax call failed and we inform the user
> * Add a trigger to force the modal close on submit success
--
This message was sent by Atlassian Jira
(v8.3.4#803005)