You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by "Jens-G (via GitHub)" <gi...@apache.org> on 2026/08/29 12:44:03 UTC

Re: [PR] THRIFT-6159 Use faster varint library in Rust [thrift]

Jens-G commented on PR #3739:
URL: https://github.com/apache/thrift/pull/3739#issuecomment-5462484293

   ### Code review
   
   Found 1 issue:
   
   1. The single commit message is `THRIFT-6159: Rust: Use faster varint library` with an empty body — it is missing the required `Client:` line (`AGENTS.md` says "Commit message format (required for code changes):" followed by "`Client: cpp,py,java   (comma-separated list of affected languages)`"). For this change it should read `Client: rs`.
   
   https://github.com/apache/thrift/blob/315a7fde4a31d640573be09d729b658cea09704e/AGENTS.md#L33-L39
   
   🤖 Generated with [Claude Code](https://claude.ai/code)
   
   <sub>- If this code review was useful, please react with 👍. Otherwise, react with 👎.</sub>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org