[jira] [Commented] (RAT-369) Add SpotBugs and checkstyle to the pom files.

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RAT-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895155#comment-17895155 ] 

ASF subversion and git services commented on RAT-369:
-----------------------------------------------------

Commit 102daf0b8a40a7995c31b2a8c0fcbe037cc299bc in creadur-rat's branch refs/heads/master from Claude Warren
[ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=102daf0b ]

RAT-439 checkstyle cleanup last pass (#382)

* initial fixes

* Fixes to make checkstyle fail on warnings

* Added checkstyle exclusions for site generation

* Fix possible NPE, minor fixes, adapt spotbugs threshold

* RAT-439, RAT-369: Add changelog about breaking builds in case of new checkstyle violations

---------

Co-authored-by: P. Ottlinger <po...@apache.org>

> Add SpotBugs and checkstyle to the pom files.
> ---------------------------------------------
>
>                 Key: RAT-369
>                 URL: https://issues.apache.org/jira/browse/RAT-369
>             Project: Apache Rat
>          Issue Type: Improvement
>          Components: Client - ant, Client - cli, Client - maven, core engine
>            Reporter: Claude Warren
>            Assignee: Philipp Ottlinger
>            Priority: Major
>             Fix For: 0.17
>
>
> Currently we have a number of issues that Spotbugs will detect.  I ran a quick test this afternoon and it found 60 potential bugs.  This ticket is to add spotbugs to the maven build, ensure that no bugs are found and ensure that the build will fail if bugs are found.
> Add checkbugs as well.
> As most of the reported errors cannot be fixed with JDK8, add exclusions for these "old"/JDK8-classes that do not allow to set a proper encoding, thus relying on the default system encoding!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)