You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avalon.apache.org by Peter Donald <do...@apache.org> on 2001/02/26 07:38:18 UTC

Changes requested

Hi,

I would like to move some files around from util.io.*. Namely move
ResettableFileInputStream.java to cornerstone with the masterstore block
because that is the only place it is used.

Remove both of MergedInputStreams.java and ByteTerminatedInputStream.java
as neither are used outside of my own projects. (James still uses it's own
copy of ByteTerminatedInputStream.java).

Also Berin what was the decision regarding ComponentNotAccessibleException
/ ComponentNotFoundException with cocoon - are they needed ?


Cheers,

Pete

*-----------------------------------------------------*
| "Faced with the choice between changing one's mind, |
| and proving that there is no need to do so - almost |
| everyone gets busy on the proof."                   |
|              - John Kenneth Galbraith               |
*-----------------------------------------------------*


Re: Changes requested

Posted by Federico Barbieri <sc...@betaversion.org>.
Peter Donald wrote:
> 
> Hi,
> 
> I would like to move some files around from util.io.*. Namely move
> ResettableFileInputStream.java to cornerstone with the masterstore block
> because that is the only place it is used.
> 
> Remove both of MergedInputStreams.java and ByteTerminatedInputStream.java
> as neither are used outside of my own projects. (James still uses it's own
> copy of ByteTerminatedInputStream.java).
> 

+0

Fede

Re: Changes requested

Posted by Berin Loritsch <bl...@apache.org>.
Peter Donald wrote:
> 
> At 09:10  26/2/01 -0500, Berin Loritsch wrote:
> >Peter Donald wrote:
> >>
> >> At 08:06  26/2/01 -0500, Berin Loritsch wrote:
> >> >> Also Berin what was the decision regarding
> ComponentNotAccessibleException
> >> >> / ComponentNotFoundException with cocoon - are they needed ?
> >> >
> >> >Really, we are only checking for ComponentManagerException.
> >>
> >> Do you mind if I deprecate them and delete after two releases ? ;)
> >
> >no, Just give me a concrete class to create--ComponentManagerException
> >can't be instantiated.
> >
> >Try this approach:
> >
> >1) Remove from 4.0 proposal
> >2) Deprecate after next release
> >3) Remove after two subsequent releases.
> >
> >There is already alot of refactoring to do because of the Configurable/
> >Configuration deprecation--it's very frustrating.  I only have so much
> >time in a day to keep things working.
> 
> Alternatively I could set a few parameters in an elisp script and run it
> over Cocoon2 and send you the diffs ? ;)

Sure, but can we do this sometime late next week.  I have a deadline to
show something useful soon, and I can't be sidetracked just yet.  It is
on my long TODO list.
> 
> cvs -z3 -q diff (in directory C:\DONALDP\xml-cocoon2\src)
> Index: org/apache/cocoon/CocoonComponentSelector.java
> ===================================================================
> RCS file:
> /home/cvspublic/xml-cocoon/src/org/apache/cocoon/Attic/CocoonComponentSelect
> or.java,v
> retrieving revision 1.1.2.23
> diff -r1.1.2.23 CocoonComponentSelector.java
> 20,21d19
> < import org.apache.avalon.ComponentNotFoundException;
> < import org.apache.avalon.ComponentNotAccessibleException;
> 111c109
> <             throw new ComponentNotFoundException("Attempted to retrieve
> component with null hint.");
> ---
> >             throw new ComponentManagerException("Attempted to retrieve
> component with null hint.");
> 125c123
> <             throw new ComponentNotFoundException("Could not find
> component for hint '" + hint.toString() + "'.");
> ---
> >             throw new ComponentManagerException("Could not find component
> for hint '" + hint.toString() + "'.");
> 130c128
> <             throw new ComponentNotAccessibleException(
> ---
> >             throw new ComponentManagerException(
> 146c144
> <                 throw new ComponentNotAccessibleException(
> ---
> >                 throw new ComponentManagerException(
> 152c150
> <                 throw new ComponentNotAccessibleException(
> ---
> >                 throw new ComponentManagerException(
> 166c164
> <                 throw new ComponentNotAccessibleException(
> ---
> >                 throw new ComponentManagerException(
> 172c170
> <                 throw new ComponentNotAccessibleException(
> ---
> >                 throw new ComponentManagerException(
> 195c193
> <             throw new ComponentNotAccessibleException("Could not set up
> the Component for hint: " + String.valueOf(hint), e);
> ---
> >             throw new ComponentManagerException("Could not set up the
> Component for hint: " + String.valueOf(hint), e);
> 236c234
> <                 throw new ComponentNotAccessibleException(
> ---
> >                 throw new ComponentManagerException(
> 250c248
> <             throw new ComponentNotAccessibleException(
> ---
> >             throw new ComponentManagerException(
> 297c295
> <                 throw new ComponentNotAccessibleException(
> ---
> >                 throw new ComponentManagerException(
> Index: org/apache/cocoon/DefaultComponentManager.java
> ===================================================================
> RCS file:
> /home/cvspublic/xml-cocoon/src/org/apache/cocoon/Attic/DefaultComponentManag
> er.java,v
> retrieving revision 1.1.2.21
> diff -r1.1.2.21 DefaultComponentManager.java
> 19,20d18
> < import org.apache.avalon.ComponentNotFoundException;
> < import org.apache.avalon.ComponentNotAccessibleException;
> 100c98
> <             throw new ComponentNotFoundException("Attempted to retrieve
> component with null role.");
> ---
> >             throw new ComponentManagerException("Attempted to retrieve
> component with null role.");
> 118c116
> <                 throw new ComponentNotFoundException("Could not find
> component for role '" + role + "'.", e);
> ---
> >                 throw new ComponentManagerException("Could not find
> component for role '" + role + "'.", e);
> 130c128
> <             throw new ComponentNotAccessibleException(
> ---
> >             throw new ComponentManagerException(
> 146c144
> <                 throw new ComponentNotAccessibleException(
> ---
> >                 throw new ComponentManagerException(
> 152c150
> <                 throw new ComponentNotAccessibleException(
> ---
> >                 throw new ComponentManagerException(
> 166c164
> <                 throw new ComponentNotAccessibleException(
> ---
> >                 throw new ComponentManagerException(
> 172c170
> <                 throw new ComponentNotAccessibleException(
> ---
> >                 throw new ComponentManagerException(
> 250c248
> <             throw new ComponentNotAccessibleException("Could not set up
> the Component for role: " + role, e);
> ---
> >             throw new ComponentManagerException("Could not set up the
> Component for role: " + role, e);
> 274c272
> <                 throw new ComponentNotAccessibleException(
> ---
> >                 throw new ComponentManagerException(
> 287c285
> <             throw new ComponentNotAccessibleException(
> ---
> >             throw new ComponentManagerException(
> 330c328
> <                 throw new ComponentNotAccessibleException(
> ---
> >                 throw new ComponentManagerException(
> Index: org/apache/cocoon/components/language/generator/GeneratorSelector.java
> ===================================================================
> RCS file:
> /home/cvspublic/xml-cocoon/src/org/apache/cocoon/components/language/generat
> or/Attic/GeneratorSelector.java,v
> retrieving revision 1.1.2.3
> diff -r1.1.2.3 GeneratorSelector.java
> 15d14
> < import org.apache.avalon.ComponentNotAccessibleException;
> 41c40
> <             throw new ComponentNotAccessibleException("Could not add
> repository to ClassLoaderManager", e);
> ---
> >             throw new ComponentManagerException("Could not add repository
> to ClassLoaderManager", e);
> 61c60
> <             throw new ComponentNotAccessibleException("Could not add
> component for class: " + className, e);
> ---
> >             throw new ComponentManagerException("Could not add component
> for class: " + className, e);
> 70c69
> < }
> \ No newline at end of file
> ---
> > }
> Index: org/apache/cocoon/generation/FileGenerator.java
> ===================================================================
> RCS file:
> /home/cvspublic/xml-cocoon/src/org/apache/cocoon/generation/Attic/FileGenera
> tor.java,v
> retrieving revision 1.1.2.22
> diff -r1.1.2.22 FileGenerator.java
> 28,29d27
> < import org.apache.avalon.ComponentNotFoundException;
> < import org.apache.avalon.ComponentNotAccessibleException;
> Index: org/apache/cocoon/servlet/CocoonServlet.java
> ===================================================================
> RCS file:
> /home/cvspublic/xml-cocoon/src/org/apache/cocoon/servlet/Attic/CocoonServlet
> .java,v
> retrieving revision 1.1.4.66
> diff -r1.1.4.66 CocoonServlet.java
> 32d31
> < import org.apache.avalon.ComponentNotAccessibleException;
> Index: org/apache/cocoon/sitemap/AbstractSitemap.java
> ===================================================================
> RCS file:
> /home/cvspublic/xml-cocoon/src/org/apache/cocoon/sitemap/Attic/AbstractSitem
> ap.java,v
> retrieving revision 1.1.2.24
> diff -r1.1.2.24 AbstractSitemap.java
> 27d26
> < import org.apache.avalon.ComponentNotFoundException;
> 90c89
> <             throw new ComponentNotFoundException ("cannot obtain the
> URLFactory", e);
> ---
> >             throw new ComponentManagerException ("cannot obtain the
> URLFactory", e);
> Index: org/apache/cocoon/sitemap/SitemapComponentSelector.java
> ===================================================================
> RCS file:
> /home/cvspublic/xml-cocoon/src/org/apache/cocoon/sitemap/Attic/SitemapCompon
> entSelector.java,v
> retrieving revision 1.1.2.2
> diff -r1.1.2.2 SitemapComponentSelector.java
> 19d18
> < import org.apache.avalon.ComponentNotFoundException;
> Cheers,
> 
> Pete
> 
> *-----------------------------------------------------*
> | "Faced with the choice between changing one's mind, |
> | and proving that there is no need to do so - almost |
> | everyone gets busy on the proof."                   |
> |              - John Kenneth Galbraith               |
> *-----------------------------------------------------*
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> For additional commands, email: cocoon-dev-help@xml.apache.org

Re: Changes requested

Posted by Peter Donald <do...@apache.org>.
At 09:10  26/2/01 -0500, Berin Loritsch wrote:
>Peter Donald wrote:
>> 
>> At 08:06  26/2/01 -0500, Berin Loritsch wrote:
>> >> Also Berin what was the decision regarding
ComponentNotAccessibleException
>> >> / ComponentNotFoundException with cocoon - are they needed ?
>> >
>> >Really, we are only checking for ComponentManagerException.
>> 
>> Do you mind if I deprecate them and delete after two releases ? ;)
>
>no, Just give me a concrete class to create--ComponentManagerException
>can't be instantiated.
>
>Try this approach:
>
>1) Remove from 4.0 proposal
>2) Deprecate after next release
>3) Remove after two subsequent releases.
>
>There is already alot of refactoring to do because of the Configurable/
>Configuration deprecation--it's very frustrating.  I only have so much
>time in a day to keep things working.

Alternatively I could set a few parameters in an elisp script and run it
over Cocoon2 and send you the diffs ? ;)

cvs -z3 -q diff (in directory C:\DONALDP\xml-cocoon2\src)
Index: org/apache/cocoon/CocoonComponentSelector.java
===================================================================
RCS file:
/home/cvspublic/xml-cocoon/src/org/apache/cocoon/Attic/CocoonComponentSelect
or.java,v
retrieving revision 1.1.2.23
diff -r1.1.2.23 CocoonComponentSelector.java
20,21d19
< import org.apache.avalon.ComponentNotFoundException;
< import org.apache.avalon.ComponentNotAccessibleException;
111c109
<             throw new ComponentNotFoundException("Attempted to retrieve
component with null hint.");
---
>             throw new ComponentManagerException("Attempted to retrieve
component with null hint.");
125c123
<             throw new ComponentNotFoundException("Could not find
component for hint '" + hint.toString() + "'.");
---
>             throw new ComponentManagerException("Could not find component
for hint '" + hint.toString() + "'.");
130c128
<             throw new ComponentNotAccessibleException(
---
>             throw new ComponentManagerException(
146c144
<                 throw new ComponentNotAccessibleException(
---
>                 throw new ComponentManagerException(
152c150
<                 throw new ComponentNotAccessibleException(
---
>                 throw new ComponentManagerException(
166c164
<                 throw new ComponentNotAccessibleException(
---
>                 throw new ComponentManagerException(
172c170
<                 throw new ComponentNotAccessibleException(
---
>                 throw new ComponentManagerException(
195c193
<             throw new ComponentNotAccessibleException("Could not set up
the Component for hint: " + String.valueOf(hint), e);
---
>             throw new ComponentManagerException("Could not set up the
Component for hint: " + String.valueOf(hint), e);
236c234
<                 throw new ComponentNotAccessibleException(
---
>                 throw new ComponentManagerException(
250c248
<             throw new ComponentNotAccessibleException(
---
>             throw new ComponentManagerException(
297c295
<                 throw new ComponentNotAccessibleException(
---
>                 throw new ComponentManagerException(
Index: org/apache/cocoon/DefaultComponentManager.java
===================================================================
RCS file:
/home/cvspublic/xml-cocoon/src/org/apache/cocoon/Attic/DefaultComponentManag
er.java,v
retrieving revision 1.1.2.21
diff -r1.1.2.21 DefaultComponentManager.java
19,20d18
< import org.apache.avalon.ComponentNotFoundException;
< import org.apache.avalon.ComponentNotAccessibleException;
100c98
<             throw new ComponentNotFoundException("Attempted to retrieve
component with null role.");
---
>             throw new ComponentManagerException("Attempted to retrieve
component with null role.");
118c116
<                 throw new ComponentNotFoundException("Could not find
component for role '" + role + "'.", e);
---
>                 throw new ComponentManagerException("Could not find
component for role '" + role + "'.", e);
130c128
<             throw new ComponentNotAccessibleException(
---
>             throw new ComponentManagerException(
146c144
<                 throw new ComponentNotAccessibleException(
---
>                 throw new ComponentManagerException(
152c150
<                 throw new ComponentNotAccessibleException(
---
>                 throw new ComponentManagerException(
166c164
<                 throw new ComponentNotAccessibleException(
---
>                 throw new ComponentManagerException(
172c170
<                 throw new ComponentNotAccessibleException(
---
>                 throw new ComponentManagerException(
250c248
<             throw new ComponentNotAccessibleException("Could not set up
the Component for role: " + role, e);
---
>             throw new ComponentManagerException("Could not set up the
Component for role: " + role, e);
274c272
<                 throw new ComponentNotAccessibleException(
---
>                 throw new ComponentManagerException(
287c285
<             throw new ComponentNotAccessibleException(
---
>             throw new ComponentManagerException(
330c328
<                 throw new ComponentNotAccessibleException(
---
>                 throw new ComponentManagerException(
Index: org/apache/cocoon/components/language/generator/GeneratorSelector.java
===================================================================
RCS file:
/home/cvspublic/xml-cocoon/src/org/apache/cocoon/components/language/generat
or/Attic/GeneratorSelector.java,v
retrieving revision 1.1.2.3
diff -r1.1.2.3 GeneratorSelector.java
15d14
< import org.apache.avalon.ComponentNotAccessibleException;
41c40
<             throw new ComponentNotAccessibleException("Could not add
repository to ClassLoaderManager", e);
---
>             throw new ComponentManagerException("Could not add repository
to ClassLoaderManager", e);
61c60
<             throw new ComponentNotAccessibleException("Could not add
component for class: " + className, e);
---
>             throw new ComponentManagerException("Could not add component
for class: " + className, e);
70c69
< }
\ No newline at end of file
---
> }
Index: org/apache/cocoon/generation/FileGenerator.java
===================================================================
RCS file:
/home/cvspublic/xml-cocoon/src/org/apache/cocoon/generation/Attic/FileGenera
tor.java,v
retrieving revision 1.1.2.22
diff -r1.1.2.22 FileGenerator.java
28,29d27
< import org.apache.avalon.ComponentNotFoundException;
< import org.apache.avalon.ComponentNotAccessibleException;
Index: org/apache/cocoon/servlet/CocoonServlet.java
===================================================================
RCS file:
/home/cvspublic/xml-cocoon/src/org/apache/cocoon/servlet/Attic/CocoonServlet
.java,v
retrieving revision 1.1.4.66
diff -r1.1.4.66 CocoonServlet.java
32d31
< import org.apache.avalon.ComponentNotAccessibleException;
Index: org/apache/cocoon/sitemap/AbstractSitemap.java
===================================================================
RCS file:
/home/cvspublic/xml-cocoon/src/org/apache/cocoon/sitemap/Attic/AbstractSitem
ap.java,v
retrieving revision 1.1.2.24
diff -r1.1.2.24 AbstractSitemap.java
27d26
< import org.apache.avalon.ComponentNotFoundException;
90c89
<             throw new ComponentNotFoundException ("cannot obtain the
URLFactory", e);
---
>             throw new ComponentManagerException ("cannot obtain the
URLFactory", e);
Index: org/apache/cocoon/sitemap/SitemapComponentSelector.java
===================================================================
RCS file:
/home/cvspublic/xml-cocoon/src/org/apache/cocoon/sitemap/Attic/SitemapCompon
entSelector.java,v
retrieving revision 1.1.2.2
diff -r1.1.2.2 SitemapComponentSelector.java
19d18
< import org.apache.avalon.ComponentNotFoundException;
Cheers,

Pete

*-----------------------------------------------------*
| "Faced with the choice between changing one's mind, |
| and proving that there is no need to do so - almost |
| everyone gets busy on the proof."                   |
|              - John Kenneth Galbraith               |
*-----------------------------------------------------*


Re: Changes requested

Posted by Peter Donald <do...@apache.org>.
At 09:10  26/2/01 -0500, Berin Loritsch wrote:
>Peter Donald wrote:
>> 
>> At 08:06  26/2/01 -0500, Berin Loritsch wrote:
>> >> Also Berin what was the decision regarding
ComponentNotAccessibleException
>> >> / ComponentNotFoundException with cocoon - are they needed ?
>> >
>> >Really, we are only checking for ComponentManagerException.
>> 
>> Do you mind if I deprecate them and delete after two releases ? ;)
>
>no, Just give me a concrete class to create--ComponentManagerException
>can't be instantiated.
>
>Try this approach:
>
>1) Remove from 4.0 proposal
>2) Deprecate after next release
>3) Remove after two subsequent releases.
>
>There is already alot of refactoring to do because of the Configurable/
>Configuration deprecation--it's very frustrating.  I only have so much
>time in a day to keep things working.

Alternatively I could set a few parameters in an elisp script and run it
over Cocoon2 and send you the diffs ? ;)

cvs -z3 -q diff (in directory C:\DONALDP\xml-cocoon2\src)
Index: org/apache/cocoon/CocoonComponentSelector.java
===================================================================
RCS file:
/home/cvspublic/xml-cocoon/src/org/apache/cocoon/Attic/CocoonComponentSelect
or.java,v
retrieving revision 1.1.2.23
diff -r1.1.2.23 CocoonComponentSelector.java
20,21d19
< import org.apache.avalon.ComponentNotFoundException;
< import org.apache.avalon.ComponentNotAccessibleException;
111c109
<             throw new ComponentNotFoundException("Attempted to retrieve
component with null hint.");
---
>             throw new ComponentManagerException("Attempted to retrieve
component with null hint.");
125c123
<             throw new ComponentNotFoundException("Could not find
component for hint '" + hint.toString() + "'.");
---
>             throw new ComponentManagerException("Could not find component
for hint '" + hint.toString() + "'.");
130c128
<             throw new ComponentNotAccessibleException(
---
>             throw new ComponentManagerException(
146c144
<                 throw new ComponentNotAccessibleException(
---
>                 throw new ComponentManagerException(
152c150
<                 throw new ComponentNotAccessibleException(
---
>                 throw new ComponentManagerException(
166c164
<                 throw new ComponentNotAccessibleException(
---
>                 throw new ComponentManagerException(
172c170
<                 throw new ComponentNotAccessibleException(
---
>                 throw new ComponentManagerException(
195c193
<             throw new ComponentNotAccessibleException("Could not set up
the Component for hint: " + String.valueOf(hint), e);
---
>             throw new ComponentManagerException("Could not set up the
Component for hint: " + String.valueOf(hint), e);
236c234
<                 throw new ComponentNotAccessibleException(
---
>                 throw new ComponentManagerException(
250c248
<             throw new ComponentNotAccessibleException(
---
>             throw new ComponentManagerException(
297c295
<                 throw new ComponentNotAccessibleException(
---
>                 throw new ComponentManagerException(
Index: org/apache/cocoon/DefaultComponentManager.java
===================================================================
RCS file:
/home/cvspublic/xml-cocoon/src/org/apache/cocoon/Attic/DefaultComponentManag
er.java,v
retrieving revision 1.1.2.21
diff -r1.1.2.21 DefaultComponentManager.java
19,20d18
< import org.apache.avalon.ComponentNotFoundException;
< import org.apache.avalon.ComponentNotAccessibleException;
100c98
<             throw new ComponentNotFoundException("Attempted to retrieve
component with null role.");
---
>             throw new ComponentManagerException("Attempted to retrieve
component with null role.");
118c116
<                 throw new ComponentNotFoundException("Could not find
component for role '" + role + "'.", e);
---
>                 throw new ComponentManagerException("Could not find
component for role '" + role + "'.", e);
130c128
<             throw new ComponentNotAccessibleException(
---
>             throw new ComponentManagerException(
146c144
<                 throw new ComponentNotAccessibleException(
---
>                 throw new ComponentManagerException(
152c150
<                 throw new ComponentNotAccessibleException(
---
>                 throw new ComponentManagerException(
166c164
<                 throw new ComponentNotAccessibleException(
---
>                 throw new ComponentManagerException(
172c170
<                 throw new ComponentNotAccessibleException(
---
>                 throw new ComponentManagerException(
250c248
<             throw new ComponentNotAccessibleException("Could not set up
the Component for role: " + role, e);
---
>             throw new ComponentManagerException("Could not set up the
Component for role: " + role, e);
274c272
<                 throw new ComponentNotAccessibleException(
---
>                 throw new ComponentManagerException(
287c285
<             throw new ComponentNotAccessibleException(
---
>             throw new ComponentManagerException(
330c328
<                 throw new ComponentNotAccessibleException(
---
>                 throw new ComponentManagerException(
Index: org/apache/cocoon/components/language/generator/GeneratorSelector.java
===================================================================
RCS file:
/home/cvspublic/xml-cocoon/src/org/apache/cocoon/components/language/generat
or/Attic/GeneratorSelector.java,v
retrieving revision 1.1.2.3
diff -r1.1.2.3 GeneratorSelector.java
15d14
< import org.apache.avalon.ComponentNotAccessibleException;
41c40
<             throw new ComponentNotAccessibleException("Could not add
repository to ClassLoaderManager", e);
---
>             throw new ComponentManagerException("Could not add repository
to ClassLoaderManager", e);
61c60
<             throw new ComponentNotAccessibleException("Could not add
component for class: " + className, e);
---
>             throw new ComponentManagerException("Could not add component
for class: " + className, e);
70c69
< }
\ No newline at end of file
---
> }
Index: org/apache/cocoon/generation/FileGenerator.java
===================================================================
RCS file:
/home/cvspublic/xml-cocoon/src/org/apache/cocoon/generation/Attic/FileGenera
tor.java,v
retrieving revision 1.1.2.22
diff -r1.1.2.22 FileGenerator.java
28,29d27
< import org.apache.avalon.ComponentNotFoundException;
< import org.apache.avalon.ComponentNotAccessibleException;
Index: org/apache/cocoon/servlet/CocoonServlet.java
===================================================================
RCS file:
/home/cvspublic/xml-cocoon/src/org/apache/cocoon/servlet/Attic/CocoonServlet
.java,v
retrieving revision 1.1.4.66
diff -r1.1.4.66 CocoonServlet.java
32d31
< import org.apache.avalon.ComponentNotAccessibleException;
Index: org/apache/cocoon/sitemap/AbstractSitemap.java
===================================================================
RCS file:
/home/cvspublic/xml-cocoon/src/org/apache/cocoon/sitemap/Attic/AbstractSitem
ap.java,v
retrieving revision 1.1.2.24
diff -r1.1.2.24 AbstractSitemap.java
27d26
< import org.apache.avalon.ComponentNotFoundException;
90c89
<             throw new ComponentNotFoundException ("cannot obtain the
URLFactory", e);
---
>             throw new ComponentManagerException ("cannot obtain the
URLFactory", e);
Index: org/apache/cocoon/sitemap/SitemapComponentSelector.java
===================================================================
RCS file:
/home/cvspublic/xml-cocoon/src/org/apache/cocoon/sitemap/Attic/SitemapCompon
entSelector.java,v
retrieving revision 1.1.2.2
diff -r1.1.2.2 SitemapComponentSelector.java
19d18
< import org.apache.avalon.ComponentNotFoundException;
Cheers,

Pete

*-----------------------------------------------------*
| "Faced with the choice between changing one's mind, |
| and proving that there is no need to do so - almost |
| everyone gets busy on the proof."                   |
|              - John Kenneth Galbraith               |
*-----------------------------------------------------*


Re: Changes requested

Posted by Berin Loritsch <bl...@apache.org>.
Peter Donald wrote:
> 
> At 08:06  26/2/01 -0500, Berin Loritsch wrote:
> >> Also Berin what was the decision regarding ComponentNotAccessibleException
> >> / ComponentNotFoundException with cocoon - are they needed ?
> >
> >Really, we are only checking for ComponentManagerException.
> 
> Do you mind if I deprecate them and delete after two releases ? ;)

no, Just give me a concrete class to create--ComponentManagerException
can't be instantiated.

Try this approach:

1) Remove from 4.0 proposal
2) Deprecate after next release
3) Remove after two subsequent releases.

There is already alot of refactoring to do because of the Configurable/
Configuration deprecation--it's very frustrating.  I only have so much
time in a day to keep things working.

Re: Changes requested

Posted by Peter Donald <do...@apache.org>.
At 08:06  26/2/01 -0500, Berin Loritsch wrote:
>> Also Berin what was the decision regarding ComponentNotAccessibleException
>> / ComponentNotFoundException with cocoon - are they needed ?
>
>Really, we are only checking for ComponentManagerException.

Do you mind if I deprecate them and delete after two releases ? ;)

Cheers,

Pete

*-----------------------------------------------------*
| "Faced with the choice between changing one's mind, |
| and proving that there is no need to do so - almost |
| everyone gets busy on the proof."                   |
|              - John Kenneth Galbraith               |
*-----------------------------------------------------*


Re: Changes requested

Posted by Berin Loritsch <bl...@apache.org>.
Peter Donald wrote:
> 
> Hi,
> 
> I would like to move some files around from util.io.*. Namely move
> ResettableFileInputStream.java to cornerstone with the masterstore block
> because that is the only place it is used.
> 
> Remove both of MergedInputStreams.java and ByteTerminatedInputStream.java
> as neither are used outside of my own projects. (James still uses it's own
> copy of ByteTerminatedInputStream.java).
> 
> Also Berin what was the decision regarding ComponentNotAccessibleException
> / ComponentNotFoundException with cocoon - are they needed ?

Really, we are only checking for ComponentManagerException.