[GitHub] [phoenix] kadirozde commented on a change in pull request #469: PHOENIX-5156 Consistent Global Indexes for Non-Transactional Tables

[GitBox <gi...@apache.org>]

kadirozde commented on a change in pull request #469: PHOENIX-5156 Consistent Global Indexes for Non-Transactional Tables
URL: https://github.com/apache/phoenix/pull/469#discussion_r273223856
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/util/IndexUtil.java
 ##########
 @@ -849,4 +855,35 @@ public static long getIndexPendingDisableCount(PhoenixConnection conn, String fa
             throw new IOException(e);
         }
     }
+
+    public static void setScanAttributes(Scan scan, PTable table, PhoenixConnection phoenixConnection) throws SQLException {
+        if (table.isTransactional() || table.isImmutableRows() || table.getType() != PTableType.INDEX) {
 
 Review comment:
   If I do that, then I need to do these checks before calling the function. Now, if the function is called in multiple places, then I need to repeat those checks. This would be error prone. Also, how do I make sure/specify for future invocations those checks will happen before this function is called?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services