[GitHub] [helix] jiajunwang commented on issue #2261: HelixManagerStateListener.OnDisconnected has never been called

[GitBox <gi...@apache.org>]

jiajunwang commented on issue #2261:
URL: https://github.com/apache/helix/issues/2261#issuecomment-1300976436

   When helixmanager.disconnet is called, the existing partition on the
   instance shall be transite to OFFLINE state. I remember that the Helix
   participant cancels any ongoing state transition during disconnection, but
   I'm not 100% sure about the detailed behavior.
   
   On the other hand, if network disconnection happens before (or without)
   HelixManager.disconnect, then from controller perspective, the participant
   is gone after ZK timeout. It will rebalance and trigger state transition on
   a new instance. The disconnected instance is partitioned from the rest of
   the cluster. So any partitions or ongoing tasks are not visible to the
   controller.
   Overall, participant connectivity is the fundamental assumption in the
   Helix controller, so everything regarding the participant relies on the
   active ZK connection.
   
   To avoid parallel and duplicate running tasks, one way is to add a handler
   to HelixManager.Ondisconnect callback. In the handler, it is possible to
   cancel the task if it has not been automatically done by the Helix
   participant (as I said, I suspect auto-cancel will be triggered but I'm not
   certain).
   
   Best Regards,
   Jiajun
   
   
   On Tue, Nov 1, 2022 at 5:00 AM joyes ***@***.***> wrote:
   
   > trying
   >
   > During worker reconnection, The controller will monitor that the worker is
   > disconnected, Will be rebalance, The same partition task is performed in
   > two workers. so Whether to associate worker reconnection with controller
   > monitoring to avoid this situation?
   >
   > —
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/helix/issues/2261#issuecomment-1298411179>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AANYM2CEH2XJKUAHJRPOAFTWGEA5LANCNFSM6AAAAAARQXKFBE>
   > .
   > You are receiving this because you commented.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org