You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "arashandishgar (via GitHub)" <gi...@apache.org> on 2025/02/19 15:09:31 UTC
[PR] GH-45578:[C++]Fix MakeStatisticsArrayMaxApproximate test case bug [arrow]
arashandishgar opened a new pull request, #45579:
URL: https://github.com/apache/arrow/pull/45579
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
The test was written for Min instead of max
### What changes are included in this PR?
correction for MaxApproximate test case
### Are these changes tested?
Yes, by dedicated unit tests.
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45578:[C++]Fix MakeStatisticsArrayMaxApproximate test case bug [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45579:
URL: https://github.com/apache/arrow/pull/45579#issuecomment-2668937381
:warning: GitHub issue #45578 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45578: [C++] Use max not min in MakeStatisticsArrayMaxApproximate test [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #45579:
URL: https://github.com/apache/arrow/pull/45579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45578: [C++] Use max not min in MakeStatisticsArrayMaxApproximate test [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #45579:
URL: https://github.com/apache/arrow/pull/45579#issuecomment-2671310420
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 01e3f1e6829d6fcc9021ac47aebb6350590ca134.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/37534895550) has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org