You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by Tanujit Ghosh <ta...@gmail.com> on 2013/08/29 04:49:35 UTC

Review Request 13894: DRILL-189 : implementation of upper() and lower() function

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13894/
-----------------------------------------------------------

Review request for drill.


Repository: drill-git


Description
-------

Implementation of upper() and lower() functions


Diffs
-----

  sandbox/prototype/exec/java-exec/src/main/codegen/ValueVectors/templates/FixedValueVectors.java 311e715 
  sandbox/prototype/exec/java-exec/src/main/codegen/ValueVectors/templates/VariableLengthVectors.java a6a6aa4 
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MathFunctions.java 78630ba 
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctions.java PRE-CREATION 
  sandbox/prototype/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestSimpleFunctions.java ce5dccd 
  sandbox/prototype/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestStringSimpleFunctions.java PRE-CREATION 
  sandbox/prototype/exec/java-exec/src/test/resources/functions/testMathFunctions.json PRE-CREATION 
  sandbox/prototype/exec/java-exec/src/test/resources/functions/testStringFunctions.json PRE-CREATION 
  sandbox/prototype/exec/java-exec/src/test/resources/logback.xml 206a469 

Diff: https://reviews.apache.org/r/13894/diff/


Testing
-------

src/test/java/org/apache/drill/exec/physical/impl/TestStringSimpleFunctions.java


Thanks,

Tanujit Ghosh