You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/01/06 02:57:40 UTC

[GitHub] [incubator-mxnet] yzhliu commented on a change in pull request #17214: [tvmop] support cuda multi-arch compilation

yzhliu commented on a change in pull request #17214: [tvmop] support cuda multi-arch compilation
URL: https://github.com/apache/incubator-mxnet/pull/17214#discussion_r363143270
 
 

 ##########
 File path: CMakeLists.txt
 ##########
 @@ -840,7 +841,7 @@ install(TARGETS ${MXNET_INSTALL_TARGETS}
 
 install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/3rdparty/dlpack/include/ DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
 install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/3rdparty/dmlc-core/include/ DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
-if(USE_MKLDNN)
+if(INSTALL_MKLDNN)
 
 Review comment:
   in cmake/BuildTVM.cmake I set `USE_MKLDNN` to OFF, does it affect this variable used later in root cmake? what is the best approach to scope an cmake option?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services