You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by al...@apache.org on 2021/02/04 17:28:15 UTC

[kudu] 02/02: [test] enable TxnStatusManagerITest.TxnKeepAliveMultiTxnStatusManagerInstances

This is an automated email from the ASF dual-hosted git repository.

alexey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git

commit 4a47e086a2edd37e725a12df7f8c11d9c8984ebd
Author: hahao <ha...@apache.org>
AuthorDate: Wed Feb 3 21:14:06 2021 -0800

    [test] enable TxnStatusManagerITest.TxnKeepAliveMultiTxnStatusManagerInstances
    
    This patch enables TxnKeepAliveMultiTxnStatusManagerInstances test in
    txn_status_manager-itest. And deflake it by decreasing the intervals
    of KeepTransactionAlive calls and reduce the RPC timeout. I looped
    TxnStatusManagerITest 100 times and it passed.
    
    Change-Id: I27afb53ecb9d28dc15fa7f0c26e677dafee2030f
    Reviewed-on: http://gerrit.cloudera.org:8080/17021
    Tested-by: Hao Hao <ha...@cloudera.com>
    Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
 src/kudu/integration-tests/txn_status_manager-itest.cc | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/kudu/integration-tests/txn_status_manager-itest.cc b/src/kudu/integration-tests/txn_status_manager-itest.cc
index 6768d2c..3ae3b86 100644
--- a/src/kudu/integration-tests/txn_status_manager-itest.cc
+++ b/src/kudu/integration-tests/txn_status_manager-itest.cc
@@ -324,7 +324,7 @@ TEST_F(TxnStatusManagerITest, ToggleStaleTxnTrackerInRuntime) {
 // sure that a transaction isn't aborted if keepalive requests are sent as
 // required even in case of Raft leader re-elections and restarts
 // of the TxnStatusManager instances.
-TEST_F(TxnStatusManagerITest, DISABLED_TxnKeepAliveMultiTxnStatusManagerInstances) {
+TEST_F(TxnStatusManagerITest, TxnKeepAliveMultiTxnStatusManagerInstances) {
   SKIP_IF_SLOW_NOT_ALLOWED();
 
   int64_t txn_id;
@@ -338,8 +338,8 @@ TEST_F(TxnStatusManagerITest, DISABLED_TxnKeepAliveMultiTxnStatusManagerInstance
   CountDownLatch latch(1);
   Status keep_txn_alive_status;
   thread txn_keepalive_sender([&] {
-    const auto period = MonoDelta::FromMilliseconds(keepalive_interval_ms / 2);
-    const auto timeout = MonoDelta::FromMilliseconds(keepalive_interval_ms / 4);
+    const auto period = MonoDelta::FromMilliseconds(keepalive_interval_ms / 5);
+    const auto timeout = MonoDelta::FromMilliseconds(keepalive_interval_ms / 10);
     // Keepalive thread uses its own messenger and proxy.
     std::shared_ptr<rpc::Messenger> m;
     rpc::MessengerBuilder b("txn-keepalive");