You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "simbit18 (via GitHub)" <gi...@apache.org> on 2024/09/20 10:30:37 UTC
[PR] build.yml: Workflow aligned with nuttx repo [nuttx-apps]
simbit18 opened a new pull request, #2591:
URL: https://github.com/apache/nuttx-apps/pull/2591
## Summary
build.yml: Limit the GitHub Runners
see https://github.com/apache/nuttx/pull/13412
## Impact
none
## Testing
CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build.yml: Workflow aligned with nuttx repo [nuttx-apps]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #2591:
URL: https://github.com/apache/nuttx-apps/pull/2591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build.yml: Workflow aligned with nuttx repo [nuttx-apps]
Posted by "simbit18 (via GitHub)" <gi...@apache.org>.
simbit18 commented on code in PR #2591:
URL: https://github.com/apache/nuttx-apps/pull/2591#discussion_r1771065486
##########
.github/workflows/build.yml:
##########
@@ -276,7 +283,7 @@ jobs:
git config --global --add safe.directory /github/workspace/sources/nuttx
git config --global --add safe.directory /github/workspace/sources/apps
cd sources/nuttx/tools/ci
- ./cibuild.sh -g -i -A -C -R testlist/${{matrix.boards}}.dat
+ ./cibuild.sh -g -i -A -C -N -R -S testlist/${{matrix.boards}}.dat
Review Comment:
Yes @lupyuen I will comment on the Pr with the requested info as soon as the CI is ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build.yml: Workflow aligned with nuttx repo [nuttx-apps]
Posted by "cederom (via GitHub)" <gi...@apache.org>.
cederom commented on code in PR #2591:
URL: https://github.com/apache/nuttx-apps/pull/2591#discussion_r1769600797
##########
.github/workflows/build.yml:
##########
@@ -117,8 +117,13 @@ jobs:
DOCKER_BUILDKIT: 1
strategy:
+ max-parallel: 12
matrix:
- boards: [arm-01, arm-02, arm-03, arm-04, arm-05, arm-06, arm-07, arm-08, arm-09, arm-10, arm-11, arm-12, arm-13, other, risc-v-01, risc-v-02, sim-01, sim-02, xtensa-01, xtensa-02]
+ boards: [
+ arm-01, other, risc-v-01, sim-01, xtensa-01,
Review Comment:
This does not seem to limit runners just change the execution order? Does this improve execution because different platforms are started first and later executions are known to fail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build.yml: Workflow aligned with nuttx repo [nuttx-apps]
Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on code in PR #2591:
URL: https://github.com/apache/nuttx-apps/pull/2591#discussion_r1771053532
##########
.github/workflows/build.yml:
##########
@@ -276,7 +283,7 @@ jobs:
git config --global --add safe.directory /github/workspace/sources/nuttx
git config --global --add safe.directory /github/workspace/sources/apps
cd sources/nuttx/tools/ci
- ./cibuild.sh -g -i -A -C -R testlist/${{matrix.boards}}.dat
+ ./cibuild.sh -g -i -A -C -N -R -S testlist/${{matrix.boards}}.dat
Review Comment:
I believe it comes from here? https://github.com/apache/nuttx/pull/13301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build.yml: Workflow aligned with nuttx repo [nuttx-apps]
Posted by "cederom (via GitHub)" <gi...@apache.org>.
cederom commented on code in PR #2591:
URL: https://github.com/apache/nuttx-apps/pull/2591#discussion_r1769600819
##########
.github/workflows/build.yml:
##########
@@ -276,7 +283,7 @@ jobs:
git config --global --add safe.directory /github/workspace/sources/nuttx
git config --global --add safe.directory /github/workspace/sources/apps
cd sources/nuttx/tools/ci
- ./cibuild.sh -g -i -A -C -R testlist/${{matrix.boards}}.dat
+ ./cibuild.sh -g -i -A -C -N -R -S testlist/${{matrix.boards}}.dat
Review Comment:
Please add description of those flags in the PR summary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build.yml: Workflow aligned with nuttx repo [nuttx-apps]
Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #2591:
URL: https://github.com/apache/nuttx-apps/pull/2591#issuecomment-2367666337
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
**Yes, this PR appears to meet the NuttX requirements.**
**Here's why:**
* **Clear Summary:** The summary clearly states the purpose of the change ("Limit the GitHub Runners") and links to the relevant NuttX pull request.
* **Minimal Impact:** The PR states there is no impact beyond the CI build process itself.
* **Testing Addressed:** While not providing specific logs, the PR confirms that testing was done within the CI environment, which is appropriate for a change focused on the build system.
**Potential Improvements:**
* **Expanded Testing:** While CI testing is great, specifying the tested host and target combinations (even briefly) would strengthen the testing section.
* **Impact Details:** Even though the impact is minimal, a sentence explaining *how* the GitHub Runners are being limited would be helpful for reviewers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build.yml: Workflow aligned with nuttx repo [nuttx-apps]
Posted by "simbit18 (via GitHub)" <gi...@apache.org>.
simbit18 commented on code in PR #2591:
URL: https://github.com/apache/nuttx-apps/pull/2591#discussion_r1771280033
##########
.github/workflows/build.yml:
##########
@@ -276,7 +283,7 @@ jobs:
git config --global --add safe.directory /github/workspace/sources/nuttx
git config --global --add safe.directory /github/workspace/sources/apps
cd sources/nuttx/tools/ci
- ./cibuild.sh -g -i -A -C -R testlist/${{matrix.boards}}.dat
+ ./cibuild.sh -g -i -A -C -N -R -S testlist/${{matrix.boards}}.dat
Review Comment:
@cederom @lupyuen done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build.yml: Workflow aligned with nuttx repo [nuttx-apps]
Posted by "simbit18 (via GitHub)" <gi...@apache.org>.
simbit18 commented on code in PR #2591:
URL: https://github.com/apache/nuttx-apps/pull/2591#discussion_r1771060960
##########
.github/workflows/build.yml:
##########
@@ -117,8 +117,13 @@ jobs:
DOCKER_BUILDKIT: 1
strategy:
+ max-parallel: 12
matrix:
- boards: [arm-01, arm-02, arm-03, arm-04, arm-05, arm-06, arm-07, arm-08, arm-09, arm-10, arm-11, arm-12, arm-13, other, risc-v-01, risc-v-02, sim-01, sim-02, xtensa-01, xtensa-02]
+ boards: [
+ arm-01, other, risc-v-01, sim-01, xtensa-01,
Review Comment:
Thanks @lupyuen
I did a rebase to see if this can fix the CI error fails on macOS jobs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build.yml: Workflow aligned with nuttx repo [nuttx-apps]
Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on code in PR #2591:
URL: https://github.com/apache/nuttx-apps/pull/2591#discussion_r1771047296
##########
.github/workflows/build.yml:
##########
@@ -117,8 +117,13 @@ jobs:
DOCKER_BUILDKIT: 1
strategy:
+ max-parallel: 12
matrix:
- boards: [arm-01, arm-02, arm-03, arm-04, arm-05, arm-06, arm-07, arm-08, arm-09, arm-10, arm-11, arm-12, arm-13, other, risc-v-01, risc-v-02, sim-01, sim-02, xtensa-01, xtensa-02]
+ boards: [
+ arm-01, other, risc-v-01, sim-01, xtensa-01,
Review Comment:
`max-parallel: 12` will limit to 12 runners. Previously it was unlimited. We limit the runners because of ASF Policy: https://lupyuen.github.io/articles/ci#appendix-phase-1-of-ci-upgrade
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org