You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ms...@apache.org on 2018/02/21 16:40:38 UTC

svn commit: r1824982 - in /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/filter: DCTFilter.java LZWFilter.java

Author: msahyoun
Date: Wed Feb 21 16:40:38 2018
New Revision: 1824982

URL: http://svn.apache.org/viewvc?rev=1824982&view=rev
Log:
PDFBOX-4118: retain exception in log message; use LOG.debug for ignored exceptions

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/filter/DCTFilter.java
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/filter/LZWFilter.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/filter/DCTFilter.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/filter/DCTFilter.java?rev=1824982&r1=1824981&r2=1824982&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/filter/DCTFilter.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/filter/DCTFilter.java Wed Feb 21 16:40:38 2018
@@ -87,6 +87,7 @@ final class DCTFilter extends Filter
                 {
                     // JAI can't read CMYK JPEGs using ImageReader#read or ImageIO.read but
                     // fortunately ImageReader#readRaster isn't buggy when reading 4-channel files
+                    LOG.debug("Couldn't read use read() for RGB image - using readRaster() as fallback", e);
                     raster = reader.readRaster(0, null);
                 }
             }
@@ -109,6 +110,7 @@ final class DCTFilter extends Filter
                 catch (IIOException | NegativeArraySizeException e)
                 {
                     // we really tried asking nicely, now we're using brute force.
+                    LOG.debug("Couldn't read usíng getAdobeTransform() - using getAdobeTransformByBruteForce() as fallback", e);
                     transform = getAdobeTransformByBruteForce(iis);
                 }
                 int colorTransform = transform != null ? transform : 0;
@@ -326,6 +328,7 @@ final class DCTFilter extends Filter
         }
         catch (IOException | NegativeArraySizeException e)
         {
+            LOG.debug("Couldn't read metadata - returning empty string", e);
             return "";
         }
     }    

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/filter/LZWFilter.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/filter/LZWFilter.java?rev=1824982&r1=1824981&r2=1824982&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/filter/LZWFilter.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/filter/LZWFilter.java Wed Feb 21 16:40:38 2018
@@ -147,7 +147,7 @@ public class LZWFilter extends Filter
         }
         catch (EOFException ex)
         {
-            LOG.warn("Premature EOF in LZW stream, EOD code missing");
+            LOG.warn("Premature EOF in LZW stream, EOD code missing", ex);
         }
         decoded.flush();
     }