You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Ruben Q L (Jira)" <ji...@apache.org> on 2020/02/05 15:13:00 UTC

[jira] [Created] (CALCITE-3773) Wrong parameter in EnumerableMergeJoin::create method

Ruben Q L created CALCITE-3773:
----------------------------------

             Summary: Wrong parameter in EnumerableMergeJoin::create method
                 Key: CALCITE-3773
                 URL: https://issues.apache.org/jira/browse/CALCITE-3773
             Project: Calcite
          Issue Type: Bug
          Components: core
    Affects Versions: 1.21.0
            Reporter: Ruben Q L
            Assignee: Ruben Q L
             Fix For: 1.22.0


The public {{EnumerableMergeJoin::create}} method takes a {{RexLiteral}} condition as parameter:
{code}
  public static EnumerableMergeJoin create(
      RelNode left, RelNode right,
      RexLiteral condition,  // here!
      ImmutableIntList leftKeys, ImmutableIntList rightKeys, JoinRelType joinType) {
    ...
  }
{code}

However, in the actual (package-private) constructor, the condition is a {{RexNode}}:
{code}
  EnumerableMergeJoin(
      RelOptCluster cluster,
      RelTraitSet traits,
      RelNode left,
      RelNode right,
      RexNode condition,  // here!
      Set<CorrelationId> variablesSet,
      JoinRelType joinType) {
    ...
  }
{code}

Therefore, the {{create}} method parameter should be modified.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)