You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by jo...@apache.org on 2022/08/19 23:23:55 UTC

[impala] 02/02: IMPALA-11294: Remove dictionary runtime filter test workarounds

This is an automated email from the ASF dual-hosted git repository.

joemcdonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit f1420ae51b2e00ad093be64a0d2135ca36aa6514
Author: Tamas Mate <tm...@cloudera.com>
AuthorDate: Thu Aug 11 17:08:46 2022 +0200

    IMPALA-11294: Remove dictionary runtime filter test workarounds
    
    This commit removes a workaround in the dictionary runtime filter tests
    that was necessary till IMPALA-11047 got merged.
    
    Testing
     - Executed e2e test locally.
    
    Change-Id: I9697f5a1a04160dd17553603b00e15d63b49e2bf
    Reviewed-on: http://gerrit.cloudera.org:8080/18839
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 tests/query_test/test_runtime_filters.py | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/tests/query_test/test_runtime_filters.py b/tests/query_test/test_runtime_filters.py
index da5913c0b..f4f51f0bb 100644
--- a/tests/query_test/test_runtime_filters.py
+++ b/tests/query_test/test_runtime_filters.py
@@ -190,19 +190,12 @@ class TestBloomFilters(ImpalaTestSuite):
 
   def test_iceberg_dictionary_runtime_filter(self, vector, unique_database):
     self.execute_query("SET ENABLED_RUNTIME_FILTER_TYPES=BLOOM")
-    self.execute_query("SET PARQUET_READ_STATISTICS=false;")
-    self.execute_query("SET MINMAX_FILTER_THRESHOLD = 0.0;")
-    self.execute_query("SET MINMAX_FILTER_SORTED_COLUMNS=FALSE;")
-    self.execute_query("SET MINMAX_FILTER_PARTITION_COLUMNS=FALSE;")
     self.run_test_case('QueryTest/iceberg-dictionary-runtime-filter', vector,
       unique_database, test_file_vars={'$RUNTIME_FILTER_WAIT_TIME_MS': str(WAIT_TIME_MS)})
 
   def test_parquet_dictionary_runtime_filter(self, vector, unique_database):
     self.execute_query("SET ENABLED_RUNTIME_FILTER_TYPES=BLOOM")
     self.execute_query("SET PARQUET_READ_STATISTICS=false;")
-    self.execute_query("SET MINMAX_FILTER_THRESHOLD = 0.0;")
-    self.execute_query("SET MINMAX_FILTER_SORTED_COLUMNS=FALSE;")
-    self.execute_query("SET MINMAX_FILTER_PARTITION_COLUMNS=FALSE;")
     self.run_test_case('QueryTest/parquet-dictionary-runtime-filter', vector,
       unique_database, test_file_vars={'$RUNTIME_FILTER_WAIT_TIME_MS': str(WAIT_TIME_MS)})