You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2023/07/18 16:44:49 UTC

[GitHub] [arrow] lidavidm opened a new issue, #36755: [C++] BaseListArray::values() should return either const shared_ptr& or const Array&, not shared_ptr

lidavidm opened a new issue, #36755:
URL: https://github.com/apache/arrow/issues/36755

   ### Describe the enhancement requested
   
   The current implementation forces a shared_ptr copy on access
   
   ### Component(s)
   
   C++


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] js8544 commented on issue #36755: [C++] BaseListArray::values() should return either const shared_ptr& or const Array&, not shared_ptr

Posted by "js8544 (via GitHub)" <gi...@apache.org>.

js8544 commented on issue #36755:
URL: https://github.com/apache/arrow/issues/36755#issuecomment-1641758009

   I believe it was changed to returning a const reference in #36418


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou commented on issue #36755: [C++] BaseListArray::values() should return either const shared_ptr& or const Array&, not shared_ptr

Posted by "pitrou (via GitHub)" <gi...@apache.org>.

pitrou commented on issue #36755:
URL: https://github.com/apache/arrow/issues/36755#issuecomment-1641766409

   Well, yes, it was. Thanks a lot @js8544 :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou commented on issue #36755: [C++] BaseListArray::values() should return either const shared_ptr& or const Array&, not shared_ptr

Posted by "pitrou (via GitHub)" <gi...@apache.org>.

pitrou commented on issue #36755:
URL: https://github.com/apache/arrow/issues/36755#issuecomment-1641680981

   cc @felipecrv 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou closed issue #36755: [C++] BaseListArray::values() should return either const shared_ptr& or const Array&, not shared_ptr

Posted by "pitrou (via GitHub)" <gi...@apache.org>.

pitrou closed issue #36755: [C++] BaseListArray::values() should return either const shared_ptr<Array>& or const Array&, not shared_ptr<Array>
URL: https://github.com/apache/arrow/issues/36755


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] lidavidm commented on issue #36755: [C++] BaseListArray::values() should return either const shared_ptr& or const Array&, not shared_ptr

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.

lidavidm commented on issue #36755:
URL: https://github.com/apache/arrow/issues/36755#issuecomment-1641982909

   Ah, sorry, I should've confirmed on main first...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] felipecrv commented on issue #36755: [C++] BaseListArray::values() should return either const shared_ptr& or const Array&, not shared_ptr

Posted by "felipecrv (via GitHub)" <gi...@apache.org>.

felipecrv commented on issue #36755:
URL: https://github.com/apache/arrow/issues/36755#issuecomment-1642474884

   @lidavidm this bothered me as well. ;-) https://github.com/apache/arrow/pull/36418#discussion_r1248318459


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org