[jira] [Commented] (TS-2174) traffic_shell/traffic_line miss some stats value

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13756881#comment-13756881 ] 

ASF subversion and git services commented on TS-2174:
-----------------------------------------------------

Commit 04e16af6dacb697ddcc373b046a7a412786caddc in branch refs/heads/master from [~yunkai]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=04e16af ]

TS-2174: Fix StatBinaryEval() on div operation

We should fore the type of result to be RecFloat on div operation,
otherwise we can't get the fraction when dividing two RecInt.

Signed-off-by: Yunkai Zhang <qi...@taobao.com>

                
> traffic_shell/traffic_line miss some stats value
> ------------------------------------------------
>
>                 Key: TS-2174
>                 URL: https://issues.apache.org/jira/browse/TS-2174
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Stats
>            Reporter: Yunkai Zhang
>            Assignee: Yunkai Zhang
>             Fix For: 4.1.0
>
>         Attachments: 0001-TS-2174-Fix-StatBinaryEval-on-div-operation.patch
>
>
> I'm sorry for too late to fix this bug.
> Here is an example about the broken of traffic_shell(reported by Esmq<es...@163.com> ):
> {code}
> echo 'show:proxy-stats' | sudo /usr/local/trafficserver/bin/traffic_shell
> Successfully Initialized MgmtAPI in /usr/local/trafficserver-4.0.1/var/trafficserver 
> trafficserver> 
> Document Hit Rate -------- 0.000000 %    *
> Ram cache Hit Rate ------- 0.000000 %    *
> Bandwidth Saving --------- 0.000000 %    *
> Cache Percent Free ------- 0.000000 %
> Open Server Connections -- 473
> Open Client Connections -- 3796
> Open Cache Connections --- 1
> Client Throughput -------- 18.100512 MBit/Sec
> Transaction Per Second --- 0.000000
> {code}
> The root cause is that StatBinaryEval() use RecInt type to hold the result of *div* operation when operands are RecInt.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira