You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@dubbo.apache.org by Imteyaz Khan <kh...@gmail.com> on 2018/12/22 10:52:57 UTC

PR raised for 3032 (Assert check and readability enhancement)

Hi All,
  I have raised the PR <https://github.com/apache/incubator-dubbo/pull/3048>for
issue number 3032. This PR has address few readability enhancement and
Assert check to simplyfy ConsumerModel constructor logic. Please review it.

https://github.com/apache/incubator-dubbo/pull/3048

Re: PR raised for 3032 (Assert check and readability enhancement)

Posted by Imteyaz Khan <kh...@gmail.com>.

Ian,
   Thanks for your appreciation.


On Tue, Dec 25, 2018 at 11:28 AM Ian Luo <ia...@gmail.com> wrote:

> Nice job, I've merged your change.
>
> Thanks,
> -Ian.
>
>
> On Sat, Dec 22, 2018 at 6:53 PM Imteyaz Khan <kh...@gmail.com>
> wrote:
>
> > Hi All,
> >   I have raised the PR <
> > https://github.com/apache/incubator-dubbo/pull/3048>for
> > issue number 3032. This PR has address few readability enhancement and
> > Assert check to simplyfy ConsumerModel constructor logic. Please review
> it.
> >
> > https://github.com/apache/incubator-dubbo/pull/3048
> >
>

Re: PR raised for 3032 (Assert check and readability enhancement)

Posted by Ian Luo <ia...@gmail.com>.

Nice job, I've merged your change.

Thanks,
-Ian.


On Sat, Dec 22, 2018 at 6:53 PM Imteyaz Khan <kh...@gmail.com> wrote:

> Hi All,
>   I have raised the PR <
> https://github.com/apache/incubator-dubbo/pull/3048>for
> issue number 3032. This PR has address few readability enhancement and
> Assert check to simplyfy ConsumerModel constructor logic. Please review it.
>
> https://github.com/apache/incubator-dubbo/pull/3048
>

Re: PR raised for 3032 (Assert check and readability enhancement)

Posted by Ian Luo <ia...@gmail.com>.

I will give it a review.

On Sat, Dec 22, 2018 at 6:53 PM Imteyaz Khan <kh...@gmail.com> wrote:

> Hi All,
>   I have raised the PR <
> https://github.com/apache/incubator-dubbo/pull/3048>for
> issue number 3032. This PR has address few readability enhancement and
> Assert check to simplyfy ConsumerModel constructor logic. Please review it.
>
> https://github.com/apache/incubator-dubbo/pull/3048
>