You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/11/26 18:12:32 UTC

[GitHub] brodybits opened a new issue #58: Plugin support for breaking Cordova platform changes

brodybits opened a new issue #58: Plugin support for breaking Cordova platform changes
URL: https://github.com/apache/cordova/issues/58
 
 
   Nice suggestion by @j3k0 in <https://github.com/apache/cordova-android/issues/585> that it should be possible for plugins to support breaking platform changes.
   
   Example by @j3k0, with edits by @brodybits:
   
   ```xml
   <plugin ...>
     <platform type="android" version="*">
       <!-- common stuff here -->
     </platform>
     <platform type="android" version="<8.0.0">
       <!-- ... -->
       <source-file src="src/android/ILib.aidl" target-dir="src/com/android/vending/billing" />
       <!-- ... -->
     </platform>
     <platform type="android" version=">=8.0.0">
       <!-- ... -->
       <lib-file src="src/android/ILib.aidl" />
       <!-- ... -->
     </platform>
   </plugin>
   ```
   
   Keep in mind that I think `version` attribute should mean Cordova platform framework, not Cordova framework version, Android OS version, Android SDK version, etc. I wonder if we can think of a smarter attribute name such as "platform-engine-version" or "cordova-platform-version" to make this clear?
   
   I think it should be possible to do this in a way that `cordova-common` would abstract this mechanism away from the Cordova platforms.
   
   I also think that the need to deal with such breaking changes should be considered an exceptional and avoided whenever practical.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org