[GitHub] [hive] deniskuzZ commented on a change in pull request #2945: HIVE-25862: Persist the time of last run of the initiator

[GitBox <gi...@apache.org>]

deniskuzZ commented on a change in pull request #2945:
URL: https://github.com/apache/hive/pull/2945#discussion_r783830501



##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
##########
@@ -6023,9 +6019,33 @@ public void releaseLocks() {
       if(derbySemaphore != null) {
         derbySemaphore.release();
       }
-      for(String key : keys) {
-        LOG.debug(quoteString(key) + " unlocked by " + quoteString(TxnHandler.hostname));
+      LOG.debug(quoteString(key1) + " unlocked by " + quoteString(TxnHandler.hostname));
+    }
+
+    @Override
+    public Long getKey2() {
+      try {
+        return rs.getLong("MT_KEY2");
+      } catch (SQLException e) {
+        LOG.warn("Couldn't resolve MT_KEY2 for MT_KEY1=" + quoteString(key1), e);
+        return -1L;
+      }
+    }
+
+    @Override
+    public void releaseLocks(Long newKey2) {

Review comment:
       can we rename key2 to timestamp




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org