You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ashb (via GitHub)" <gi...@apache.org> on 2026/10/12 17:57:59 UTC
[PR] Let the Breeze shell skip forwarding ports to the host [airflow]
ashb opened a new pull request, #74607:
URL: https://github.com/apache/airflow/pull/74607
The Breeze shell always publishes its SSH, API server, Flower and database
ports, so a second shell -- for example from another worktree -- fails to
start with "port is already allocated" while any other Breeze container
holds them. Changing every port through the *_HOST_PORT variables works but
is a lot to set for a shell that does not need them.
--no-forward-ports (or FORWARD_PORTS=false) on breeze and breeze shell skips
publishing them. Forwarding stays the default, so existing shells keep
their ports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Let the Breeze shell skip forwarding ports to the host [airflow]
Posted by "seanghaeli (via GitHub)" <gi...@apache.org>.
seanghaeli commented on code in PR #74607:
URL: https://github.com/apache/airflow/pull/74607#discussion_r4331326408
##########
dev/breeze/doc/03_developer_tasks.rst:
##########
@@ -205,6 +205,9 @@ You can change the used host port numbers by setting appropriate environment var
If you set these variables, next time when you enter the environment the new ports should be in effect.
+To not forward any ports, for example to open a second Breeze shell while another Breeze container already
+holds them, pass ``--no-forward-ports`` or set ``FORWARD_PORTS=false``.
+
Review Comment:
Quick thing about the docs:
Under the current wording it looks like `breeze --no-forward-ports shell` would work, but this silently still port forwards, so the docs should explicitly say `breeze shell --no-forward-ports`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Let the Breeze shell skip forwarding ports to the host [airflow]
Posted by "Andrushika (via GitHub)" <gi...@apache.org>.
Andrushika commented on code in PR #74607:
URL: https://github.com/apache/airflow/pull/74607#discussion_r4261452194
##########
dev/breeze/doc/03_developer_tasks.rst:
##########
@@ -205,6 +205,9 @@ You can change the used host port numbers by setting appropriate environment var
If you set these variables, next time when you enter the environment the new ports should be in effect.
+To not forward any ports, for example to open a second Breeze shell while another Breeze container already
Review Comment:
"To not forward any ports" seems a bit inaccurate here?
Some integrations (e.g. Redis) still forward their ports to the host. Do we want to include these ports too?
(Or we could simply reword this sentence)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Let the Breeze shell skip forwarding ports to the host [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #74607:
URL: https://github.com/apache/airflow/pull/74607#discussion_r4256836459
##########
dev/breeze/doc/03_developer_tasks.rst:
##########
@@ -205,6 +205,9 @@ You can change the used host port numbers by setting appropriate environment var
If you set these variables, next time when you enter the environment the new ports should be in effect.
+To not forward any ports, for example to open a second Breeze shell while another Breeze container already
+holds them, pass ``--no-forward-ports`` or set ``FORWARD_PORTS=false``.
Review Comment:
It's always command line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Let the Breeze shell skip forwarding ports to the host [airflow]
Posted by "Andrushika (via GitHub)" <gi...@apache.org>.
Andrushika commented on code in PR #74607:
URL: https://github.com/apache/airflow/pull/74607#discussion_r4261452194
##########
dev/breeze/doc/03_developer_tasks.rst:
##########
@@ -205,6 +205,9 @@ You can change the used host port numbers by setting appropriate environment var
If you set these variables, next time when you enter the environment the new ports should be in effect.
+To not forward any ports, for example to open a second Breeze shell while another Breeze container already
Review Comment:
"To not forward any ports" seems a bit inaccurate here?
Some integrations (e.g. Redis) still forward their ports to the host.
Do we want to include these ports too? (I guess not... we could simply reword the sentence here, listing the four ports)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Let the Breeze shell skip forwarding ports to the host [airflow]
Posted by "SameerMesiah97 (via GitHub)" <gi...@apache.org>.
SameerMesiah97 commented on code in PR #74607:
URL: https://github.com/apache/airflow/pull/74607#discussion_r4251232469
##########
dev/breeze/doc/03_developer_tasks.rst:
##########
@@ -205,6 +205,9 @@ You can change the used host port numbers by setting appropriate environment var
If you set these variables, next time when you enter the environment the new ports should be in effect.
+To not forward any ports, for example to open a second Breeze shell while another Breeze container already
+holds them, pass ``--no-forward-ports`` or set ``FORWARD_PORTS=false``.
Review Comment:
Which one should take precedence? The value set via the flag or the environment variable? What happens when both contradict?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org