You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by "rishabhdaim (via GitHub)" <gi...@apache.org> on 2026/03/09 16:25:05 UTC
[PR] OAK-11300 : remove unused common.graph export from oak-shaded-guava [jackrabbit-oak]
rishabhdaim opened a new pull request, #2791:
URL: https://github.com/apache/jackrabbit-oak/pull/2791
## Summary
Removes the `${pref}.common.graph` entry from the `Export-Package` section in `oak-shaded-guava/pom.xml`. No Java code in the repository imports from `org.apache.jackrabbit.guava.common.graph`, so exporting this package is unnecessary.
## Changes
- `oak-shaded-guava/pom.xml` — removed `${pref}.common.graph;version="33.4.1"` from `Export-Package`
## Test Plan
- [ ] `mvn clean install -DskipTests=true -pl oak-shaded-guava` passes
## Links
- JIRA: https://issues.apache.org/jira/browse/OAK-11300
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11300 : remove unused common.graph export from oak-shaded-guava [jackrabbit-oak]
Posted by "rishabhdaim (via GitHub)" <gi...@apache.org>.
rishabhdaim merged PR #2791:
URL: https://github.com/apache/jackrabbit-oak/pull/2791
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11300 : remove unused common.graph export from oak-shaded-guava [jackrabbit-oak]
Posted by "rishabhdaim (via GitHub)" <gi...@apache.org>.
rishabhdaim commented on code in PR #2791:
URL: https://github.com/apache/jackrabbit-oak/pull/2791#discussion_r2907077994
##########
oak-shaded-guava/pom.xml:
##########
Review Comment:
addressed in https://github.com/apache/jackrabbit-oak/pull/2791/commits/d52c0f52ac1946713e8b2b84bf09105187ba40f0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11300 : remove unused common.graph export from oak-shaded-guava [jackrabbit-oak]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #2791:
URL: https://github.com/apache/jackrabbit-oak/pull/2791#issuecomment-4029168691
## [](https://sonarcloud.io/dashboard?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2791) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2791&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2791&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2791&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2791&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2791&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2791)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11300 : remove unused common.graph export from oak-shaded-guava [jackrabbit-oak]
Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke commented on code in PR #2791:
URL: https://github.com/apache/jackrabbit-oak/pull/2791#discussion_r2906844895
##########
oak-shaded-guava/pom.xml:
##########
Review Comment:
We can exclude it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11300 : remove unused common.graph export from oak-shaded-guava [jackrabbit-oak]
Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke commented on PR #2791:
URL: https://github.com/apache/jackrabbit-oak/pull/2791#issuecomment-4025435211
I'll also add that the test plan is insufficient for obvious reasons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org