You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2023/05/23 11:36:34 UTC
[GitHub] [pulsar] lhotari opened a new pull request, #20372: [fix][broker] Change some static fields referencing mutable objects to ordinary instance fields in BrokerService
lhotari opened a new pull request, #20372:
URL: https://github.com/apache/pulsar/pull/20372
### Motivation
Mutable objects shouldn't be static fields in BrokerService
### Modifications
Drop `static` definition and make them ordinary instance fields.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #20372: [fix][broker] Change some static fields referencing mutable objects to ordinary instance fields in BrokerService
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #20372:
URL: https://github.com/apache/pulsar/pull/20372#issuecomment-1559633722
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #20372: [fix][broker] Change some static fields referencing mutable objects to ordinary instance fields in BrokerService
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #20372:
URL: https://github.com/apache/pulsar/pull/20372#issuecomment-1559131930
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #20372: [fix][broker] Change some static fields referencing mutable objects to ordinary instance fields in BrokerService
Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat merged PR #20372:
URL: https://github.com/apache/pulsar/pull/20372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org