You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/02/08 20:20:56 UTC
[GitHub] [netbeans] lkishalmi opened a new pull request #1936: Heapview
FlatLaF alternative colors
lkishalmi opened a new pull request #1936: Heapview FlatLaF alternative colors
URL: https://github.com/apache/netbeans/pull/1936
Well, this is just an alternative coloring of the HeapView on FlatLaF. Personally I think the yellow draws more attention to the eye than it should be. I also changed the view background color match the toolbar so it is more flat that way. If agreed it is trivial to merge for 11.3.
See the samples:
@DevCharly, @pedro-w ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on issue #1936: Heapview FlatLaF
alternative colors
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on issue #1936: Heapview FlatLaF alternative colors
URL: https://github.com/apache/netbeans/pull/1936#issuecomment-583858140
Oh, just a before illustration:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on issue #1936: Heapview FlatLaF
alternative colors
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on issue #1936: Heapview FlatLaF alternative colors
URL: https://github.com/apache/netbeans/pull/1936#issuecomment-583948453
I don't have a strong opinion on this one... the function seems to be preserved well enough without an explicit max point, since the top and bottom of the plot area is symmetrical around the overlaid text (which shows the max in any case). I think the main function of the plot is to show changes in memory consumption over time, while the text shows the exact current ratio.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on issue #1936: Heapview FlatLaF
alternative colors
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on issue #1936: Heapview FlatLaF alternative colors
URL: https://github.com/apache/netbeans/pull/1936#issuecomment-583890008
Well, the possible maximum is vary especially on G1. I agree that having a different color as background would be more informative, but the question is that do we need to be that informative or just looking cool is enough. In this case I'd vote for the second one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] GeertjanWielenga commented on issue #1936: Heapview
FlatLaF alternative colors
Posted by GitBox <gi...@apache.org>.
GeertjanWielenga commented on issue #1936: Heapview FlatLaF alternative colors
URL: https://github.com/apache/netbeans/pull/1936#issuecomment-583859409
I like it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi merged pull request #1936: Heapview FlatLaF
alternative colors
Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #1936: Heapview FlatLaF alternative colors
URL: https://github.com/apache/netbeans/pull/1936
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] graben commented on issue #1936: Heapview FlatLaF
alternative colors
Posted by GitBox <gi...@apache.org>.
graben commented on issue #1936: Heapview FlatLaF alternative colors
URL: https://github.com/apache/netbeans/pull/1936#issuecomment-583860798
Might be a bit too "flat" without the background difference of the chart panel. This way the possible maximum is not visible but blue is definitely much better than yellow. ;-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on issue #1936: Heapview FlatLaF
alternative colors
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on issue #1936: Heapview FlatLaF alternative colors
URL: https://github.com/apache/netbeans/pull/1936#issuecomment-583803226
Looks nice! Perhaps the "flat" (panel-colored) background should just be used for the regular LAF as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] AlexFalappa commented on issue #1936: Heapview FlatLaF
alternative colors
Posted by GitBox <gi...@apache.org>.
AlexFalappa commented on issue #1936: Heapview FlatLaF alternative colors
URL: https://github.com/apache/netbeans/pull/1936#issuecomment-584125389
I roughly agree with @graben, blue better than yellow and if the background would be a bit different would help to understand the chart extension.
However I have no strong opinions on this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists