You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2012/07/06 10:40:36 UTC

[jira] [Created] (WICKET-4640) ResourceBundleReference doesn't need a ResourceReference as constructor parameter

Martin Grigorov created WICKET-4640:
---------------------------------------

             Summary: ResourceBundleReference doesn't need a ResourceReference as constructor parameter
                 Key: WICKET-4640
                 URL: https://issues.apache.org/jira/browse/WICKET-4640
             Project: Wicket
          Issue Type: Improvement
          Components: wicket
    Affects Versions: 6.0.0-beta2
            Reporter: Martin Grigorov
            Assignee: Martin Grigorov


org.apache.wicket.resource.bundles.ResourceBundleReference#ResourceBundleReference uses the passed ResourceReference just to read its scope, name, style, locale and variation.

A reference to this ResRef is stored but never used or exposed via getter.
I see no reason to create a ResRef to pass it to ResBundleRef while the user can just pass the attributes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WICKET-4640) ResourceBundleReference doesn't need a ResourceReference as constructor parameter

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-4640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407824#comment-13407824 ] 

Martin Grigorov commented on WICKET-4640:
-----------------------------------------

Actually there is a getter and it is used in BasicResourceReferenceMapper
                
> ResourceBundleReference doesn't need a ResourceReference as constructor parameter
> ---------------------------------------------------------------------------------
>
>                 Key: WICKET-4640
>                 URL: https://issues.apache.org/jira/browse/WICKET-4640
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 6.0.0-beta2
>            Reporter: Martin Grigorov
>            Assignee: Martin Grigorov
>
> org.apache.wicket.resource.bundles.ResourceBundleReference#ResourceBundleReference uses the passed ResourceReference just to read its scope, name, style, locale and variation.
> A reference to this ResRef is stored but never used or exposed via getter.
> I see no reason to create a ResRef to pass it to ResBundleRef while the user can just pass the attributes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (WICKET-4640) ResourceBundleReference doesn't need a ResourceReference as constructor parameter

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-4640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-4640.
-------------------------------------

    Resolution: Not A Problem
    
> ResourceBundleReference doesn't need a ResourceReference as constructor parameter
> ---------------------------------------------------------------------------------
>
>                 Key: WICKET-4640
>                 URL: https://issues.apache.org/jira/browse/WICKET-4640
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 6.0.0-beta2
>            Reporter: Martin Grigorov
>            Assignee: Martin Grigorov
>
> org.apache.wicket.resource.bundles.ResourceBundleReference#ResourceBundleReference uses the passed ResourceReference just to read its scope, name, style, locale and variation.
> A reference to this ResRef is stored but never used or exposed via getter.
> I see no reason to create a ResRef to pass it to ResBundleRef while the user can just pass the attributes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira