You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "eirikbakke (via GitHub)" <gi...@apache.org> on 2025/10/15 06:02:16 UTC
[PR] Suppress 'loadImage called with unusual URI: ergoloc:/...' log message [netbeans]
eirikbakke opened a new pull request, #8917:
URL: https://github.com/apache/netbeans/pull/8917
The ImageUtilities.loadImage(URL) method was [added](https://github.com/apache/netbeans/pull/8114) earlier to help migrate Toolkit.getImage(URL) calls to ImageUtilities-based loading (to support SVG icons etc.).
As mentioned [here](https://github.com/apache/netbeans/pull/8239#issuecomment-2654826772), there are occasionally icon loading attempts with the special URL scheme "ergoloc", which caused some warnings in the IDE log.
This PR suppresses said warning messages, while adding a softer INFO log entry for a more specific case that we have yet to observe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Suppress 'loadImage called with unusual URI: ergoloc:/...' log message [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #8917:
URL: https://github.com/apache/netbeans/pull/8917#issuecomment-3407274611
Post merge approval! :smile: Thanks.
Notes make sense - at some point we need to look at all the icons in the ergonomics module and how they're generated / included, should include any SVGs, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Suppress 'loadImage called with unusual URI: ergoloc:/...' log message [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #8917:
URL: https://github.com/apache/netbeans/pull/8917#issuecomment-3407394678
Have you looked inside the compiled ergonomics module JAR? That file is in there as far as I can see, as are many icons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Suppress 'loadImage called with unusual URI: ergoloc:/...' log message [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #8917:
URL: https://github.com/apache/netbeans/pull/8917#issuecomment-3407316647
Actually, I'm not sure this is the right approach? @jtulach ? Looking at https://github.com/apache/netbeans/blob/master/ergonomics/ide.ergonomics/src/org/netbeans/modules/ide/ergonomics/fod/FoDURLStreamHandler.java#L44 this just delegates to `nbresloc` directly for anything that isn't HTML? In which case, can we just use the same `nbresloc` behaviour for `ergoloc` too in https://github.com/apache/netbeans/blob/master/platform/openide.util.ui/src/org/openide/util/ImageUtilities.java#L232 ?
A bit ugly that the platform needs to know about `ergoloc` at all, but it has to do that to suppress the message too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Suppress 'loadImage called with unusual URI: ergoloc:/...' log message [netbeans]
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke merged PR #8917:
URL: https://github.com/apache/netbeans/pull/8917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Suppress 'loadImage called with unusual URI: ergoloc:/...' log message [netbeans]
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke commented on PR #8917:
URL: https://github.com/apache/netbeans/pull/8917#issuecomment-3407370830
I don't quite understand what the ergoloc scheme is used for, or how the "ergoloc:/org/netbeans/modules/ide/ergonomics/enterprise/org-netbeans-modules-websvc-core-client-resources-ws_client_16.png" URL arose in the first place; it doesn't point to a valid image, and it comes from a layer attribute that was auto-generated by an ant script somewhere. Reading through FoDURLStreamHandler it could appear that ergoloc is really only meant to be used for HTML files? Or not...
So anyway, the current PR just maintains the status quo for ergoloc URLs, and suppresses the warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists