Re: Review Request 20659: CLOUDSTACK-5674: Fixed cloudstackConnection.py to return FAILED in case of well handled exceptions returning from server having jobresultcode as 530

[ASF Subversion and Git Services <as...@urd.zones.apache.org>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20659/#review48899
-----------------------------------------------------------


Commit 4a99cf851966512ae90633b7ed7d7954b6d0ac9a in cloudstack's branch refs/heads/4.4 from SrikanteswaraRao Talluri
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4a99cf8 ]

CLOUDSTACK-5674:Fixed pep8 errors in python files in marvin folder
Signed-off-by: SrikanteswaraRao Talluri <ta...@apache.org>

(cherry picked from commit 4f1f182cba5579da2fc7ce1f02019a0afa00efeb)

Conflicts:
	tools/marvin/marvin/lib/base.py


- ASF Subversion and Git Services


On May 12, 2014, 6:04 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20659/
> -----------------------------------------------------------
> 
> (Updated May 12, 2014, 6:04 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5674
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5674
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> In case of well handled exceptions returned from the server with proper error message, the response was as it is returned. Instead, it should check the jobresultcode. If the jobresultcode is 530, it means that exception is returned from server. In this case we should return FAILED.
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/cloudstackConnection.py 8044da7 
>   tools/marvin/marvin/codes.py ef49c0c 
> 
> Diff: https://reviews.apache.org/r/20659/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>