You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by ko...@apache.org on 2023/03/17 02:44:16 UTC

[arrow] branch main updated: GH-34597: [Packaging][RPM] Don't use glog (#34598)

This is an automated email from the ASF dual-hosted git repository.

kou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/main by this push:
     new f9324b79bf GH-34597: [Packaging][RPM] Don't use glog (#34598)
f9324b79bf is described below

commit f9324b79bf4fc1ec7e97b32e3cce16e75ef0f5e3
Author: Sutou Kouhei <ko...@cozmixng.org>
AuthorDate: Fri Mar 17 11:44:08 2023 +0900

    GH-34597: [Packaging][RPM] Don't use glog (#34598)
    
    ### Rationale for this change
    
    Because glog depends on gflags-devel.
    
    ### What changes are included in this PR?
    
    Don't use glog.
    
    ### Are these changes tested?
    
    Yes.
    
    ### Are there any user-facing changes?
    
    Yes.
    * Closes: #34597
    
    Lead-authored-by: Sutou Kouhei <ko...@clear-code.com>
    Co-authored-by: Sutou Kouhei <ko...@cozmixng.org>
    Co-authored-by: Jacob Wujciak-Jens <ja...@wujciak.de>
    Signed-off-by: Sutou Kouhei <ko...@clear-code.com>
---
 dev/tasks/linux-packages/apache-arrow/yum/arrow.spec.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/dev/tasks/linux-packages/apache-arrow/yum/arrow.spec.in b/dev/tasks/linux-packages/apache-arrow/yum/arrow.spec.in
index 8b4a4a44fd..e6808fdcee 100644
--- a/dev/tasks/linux-packages/apache-arrow/yum/arrow.spec.in
+++ b/dev/tasks/linux-packages/apache-arrow/yum/arrow.spec.in
@@ -70,7 +70,9 @@
 %define use_gandiva (%{rhel} >= 8 && "%{_arch}" != "aarch64")
 %define use_gcs (%{rhel} >= 8)
 %define use_gflags (!%{is_amazon_linux})
-%define use_glog (%{rhel} <= 8)
+## TODO: Enable this when glog stopped depending on gflags-devel.
+# %%define use_glog (%{rhel} <= 8)
+%define use_glog 0
 %define use_mimalloc (%{rhel} >= 8)
 # TODO: Enable this. This works on local but is fragile on GitHub Actions and
 # Travis CI.