You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/11/24 04:51:03 UTC
[GitHub] [netbeans] BradWalker opened a new pull request, #5004: Cleanup few remaining raw type List warnings..
BradWalker opened a new pull request, #5004:
URL: https://github.com/apache/netbeans/pull/5004
There are a few remaining rawy type List warnings remaining.. This try to clean the bulk of them up. It's been a slog to get all this done..
[repeat] /home/bwalker/src/netbeans/ide/editor/src/org/netbeans/modules/editor/NbEditorKit.java:712: warning: [unchecked] unchecked call to add(E) as a member of the raw type List
[repeat] l.add(action);
[repeat] ^
[repeat] where E is a type-variable:
[repeat] E extends Object declared in interface List
---
**^Add meaningful description above**
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
- are all your own work, and you have the right to contribute them.
- are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).
Please make sure (eg. `git log`) that all commits have a valid name and email address for you in the Author field.
If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a diff in pull request #5004: Cleanup few remaining raw type List warnings..
Posted by GitBox <gi...@apache.org>.
BradWalker commented on code in PR #5004:
URL: https://github.com/apache/netbeans/pull/5004#discussion_r1036608847
##########
enterprise/web.core/src/org/netbeans/modules/web/core/api/JspColoringData.java:
##########
@@ -118,9 +118,9 @@ public void parsingStarted() {
/** Incorporates new parse data from the parser, possibly firing a change about coloring.
* @param newTaglibs the new map of (uri -> TagLibraryInfo)
* @param newPrefixMapper the new map of (prefix, uri)
- * @param parseSuccessful wherher parsing was successful. If false, then the new information is partial only
+ * @param parseSuccessful wheher parsing was successful. If false, then the new information is partial only
Review Comment:
Hey @tonihele , yep.. Good eyes.. 8-)
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on pull request #5004: Cleanup few remaining raw type List warnings..
Posted by GitBox <gi...@apache.org>.
BradWalker commented on PR #5004:
URL: https://github.com/apache/netbeans/pull/5004#issuecomment-1333024997
> There are lot of these old Hashtables. I think they should be evaluated whether synchronization is really needed. If it is needed, changing them to ConcurrentHashMap, otherwise HashMap.
>
> Oh, and this is just food for thought. I'm not affiliated with Netbeans development in any way :)
Hey @tonihele , right you are.. It's on my radar..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker merged pull request #5004: Cleanup few remaining raw type List warnings..
Posted by GitBox <gi...@apache.org>.
BradWalker merged PR #5004:
URL: https://github.com/apache/netbeans/pull/5004
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tonihele commented on a diff in pull request #5004: Cleanup few remaining raw type List warnings..
Posted by GitBox <gi...@apache.org>.
tonihele commented on code in PR #5004:
URL: https://github.com/apache/netbeans/pull/5004#discussion_r1034367564
##########
enterprise/web.core/src/org/netbeans/modules/web/core/api/JspColoringData.java:
##########
@@ -118,9 +118,9 @@ public void parsingStarted() {
/** Incorporates new parse data from the parser, possibly firing a change about coloring.
* @param newTaglibs the new map of (uri -> TagLibraryInfo)
* @param newPrefixMapper the new map of (prefix, uri)
- * @param parseSuccessful wherher parsing was successful. If false, then the new information is partial only
+ * @param parseSuccessful wheher parsing was successful. If false, then the new information is partial only
Review Comment:
Should it be _whether_?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tonihele commented on pull request #5004: Cleanup few remaining raw type List warnings..
Posted by GitBox <gi...@apache.org>.
tonihele commented on PR #5004:
URL: https://github.com/apache/netbeans/pull/5004#issuecomment-1330178573
There are lot of these old Hashtables. I think they should be evaluated whether synchronization is really needed. If it is needed, changing them to ConcurrentHashMap, otherwise HashMap.
Oh, and this is just food for thought. I'm not affiliated with Netbeans development in any way :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists