You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/12 14:12:08 UTC
[GitHub] [superset] michael-s-molina opened a new pull request #12450: chore: apply capitalization guidelines - iteration 4 (#12343)
michael-s-molina opened a new pull request #12450:
URL: https://github.com/apache/superset/pull/12450
### SUMMARY
Apply capitalization guidelines defined in #12343.
@junlincc
### TEST PLAN
Check if modified texts are following capitalization guidelines.
### ADDITIONAL INFORMATION
- [x] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12450: chore: apply capitalization guidelines - iteration 4 (#12343)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12450:
URL: https://github.com/apache/superset/pull/12450#issuecomment-758737541
# [Codecov](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=h1) Report
> Merging [#12450](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=desc) (1937724) into [master](https://codecov.io/gh/apache/superset/commit/5504762458e127063e36f5aa149bbdf3f6fc8f80?el=desc) (5504762) will **decrease** coverage by `0.91%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12450 +/- ##
==========================================
- Coverage 64.55% 63.64% -0.92%
==========================================
Files 1018 486 -532
Lines 49787 29970 -19817
Branches 4971 0 -4971
==========================================
- Hits 32141 19075 -13066
+ Misses 17468 10895 -6573
+ Partials 178 0 -178
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.64% <ø> (-0.49%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-6.71%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `93.42% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.68% <0.00%> (-0.47%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/migrations/shared/security\_converge.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9zaGFyZWQvc2VjdXJpdHlfY29udmVyZ2UucHk=) | `86.82% <0.00%> (-0.11%)` | :arrow_down: |
| ... and [528 more](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=footer). Last update [5504762...1937724](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #12450: chore: apply capitalization guidelines - iteration 4 (#12343)
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #12450:
URL: https://github.com/apache/superset/pull/12450#issuecomment-758726965
@steejay @mihir174 since Design will review this PR, to make it easier for them, please give a list of menu items that has changed in the description. @michael-s-molina
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12450: chore: apply capitalization guidelines - iteration 4 (#12343)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12450:
URL: https://github.com/apache/superset/pull/12450#issuecomment-758737541
# [Codecov](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=h1) Report
> Merging [#12450](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=desc) (1097f6e) into [master](https://codecov.io/gh/apache/superset/commit/078a8a17a1883ace050bc3baa0bd500e300e61b1?el=desc) (078a8a1) will **decrease** coverage by `4.54%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12450 +/- ##
==========================================
- Coverage 66.81% 62.26% -4.55%
==========================================
Files 1015 1015
Lines 49544 49528 -16
Branches 5080 5080
==========================================
- Hits 33102 30839 -2263
- Misses 16312 18480 +2168
- Partials 130 209 +79
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.75% <50.00%> (ø)` | |
| python | `63.25% <ø> (-0.83%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `10.71% <0.00%> (-39.29%)` | :arrow_down: |
| [...hboard/components/nativeFilters/CascadePopover.tsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvQ2FzY2FkZVBvcG92ZXIudHN4) | `22.64% <ø> (ø)` | |
| [...c/dashboard/components/nativeFilters/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyLnRzeA==) | `52.48% <ø> (-1.04%)` | :arrow_down: |
| [...oard/components/nativeFilters/FilterConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnRm9ybS50c3g=) | `80.35% <ø> (-1.79%)` | :arrow_down: |
| [...dashboard/components/nativeFilters/FiltersList.tsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0xpc3QudHN4) | `0.00% <ø> (ø)` | |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `60.86% <ø> (ø)` | |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `84.81% <ø> (+1.06%)` | :arrow_up: |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `67.09% <ø> (ø)` | |
| [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `59.75% <100.00%> (-3.28%)` | :arrow_down: |
| ... and [223 more](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=footer). Last update [078a8a1...1097f6e](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12450: chore: apply capitalization guidelines - iteration 4 (#12343)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12450:
URL: https://github.com/apache/superset/pull/12450#issuecomment-758737541
# [Codecov](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=h1) Report
> Merging [#12450](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=desc) (1097f6e) into [master](https://codecov.io/gh/apache/superset/commit/078a8a17a1883ace050bc3baa0bd500e300e61b1?el=desc) (078a8a1) will **decrease** coverage by `4.24%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12450 +/- ##
==========================================
- Coverage 66.81% 62.56% -4.25%
==========================================
Files 1015 1015
Lines 49544 49530 -14
Branches 5080 5080
==========================================
- Hits 33102 30990 -2112
- Misses 16312 18331 +2019
- Partials 130 209 +79
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.75% <50.00%> (ø)` | |
| python | `63.75% <ø> (-0.33%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `10.71% <0.00%> (-39.29%)` | :arrow_down: |
| [...hboard/components/nativeFilters/CascadePopover.tsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvQ2FzY2FkZVBvcG92ZXIudHN4) | `22.64% <ø> (ø)` | |
| [...c/dashboard/components/nativeFilters/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyLnRzeA==) | `52.48% <ø> (-1.04%)` | :arrow_down: |
| [...oard/components/nativeFilters/FilterConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnRm9ybS50c3g=) | `80.35% <ø> (-1.79%)` | :arrow_down: |
| [...dashboard/components/nativeFilters/FiltersList.tsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0xpc3QudHN4) | `0.00% <ø> (ø)` | |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `60.86% <ø> (ø)` | |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `84.81% <ø> (+1.06%)` | :arrow_up: |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `67.09% <ø> (ø)` | |
| [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `59.75% <100.00%> (-3.28%)` | :arrow_down: |
| ... and [219 more](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=footer). Last update [078a8a1...1097f6e](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12450: chore: apply capitalization guidelines - iteration 4 (#12343)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12450:
URL: https://github.com/apache/superset/pull/12450#issuecomment-758737541
# [Codecov](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=h1) Report
> Merging [#12450](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=desc) (3bb35e0) into [master](https://codecov.io/gh/apache/superset/commit/5504762458e127063e36f5aa149bbdf3f6fc8f80?el=desc) (5504762) will **decrease** coverage by `1.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12450 +/- ##
==========================================
- Coverage 64.55% 63.34% -1.22%
==========================================
Files 1018 486 -532
Lines 49787 29983 -19804
Branches 4971 0 -4971
==========================================
- Hits 32141 18992 -13149
+ Misses 17468 10991 -6477
+ Partials 178 0 -178
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.34% <ø> (-0.79%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.31% <0.00%> (-6.28%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.59% <0.00%> (-3.27%)` | :arrow_down: |
| ... and [533 more](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=footer). Last update [5504762...3bb35e0](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12450: chore: apply capitalization guidelines - iteration 4 (#12343)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12450:
URL: https://github.com/apache/superset/pull/12450#issuecomment-758737541
# [Codecov](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=h1) Report
> Merging [#12450](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=desc) (1097f6e) into [master](https://codecov.io/gh/apache/superset/commit/078a8a17a1883ace050bc3baa0bd500e300e61b1?el=desc) (078a8a1) will **decrease** coverage by `4.24%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12450 +/- ##
==========================================
- Coverage 66.81% 62.56% -4.25%
==========================================
Files 1015 1015
Lines 49544 49530 -14
Branches 5080 5080
==========================================
- Hits 33102 30990 -2112
- Misses 16312 18331 +2019
- Partials 130 209 +79
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.75% <50.00%> (ø)` | |
| python | `63.75% <ø> (-0.33%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `10.71% <0.00%> (-39.29%)` | :arrow_down: |
| [...hboard/components/nativeFilters/CascadePopover.tsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvQ2FzY2FkZVBvcG92ZXIudHN4) | `22.64% <ø> (ø)` | |
| [...c/dashboard/components/nativeFilters/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyLnRzeA==) | `52.48% <ø> (-1.04%)` | :arrow_down: |
| [...oard/components/nativeFilters/FilterConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnRm9ybS50c3g=) | `80.35% <ø> (-1.79%)` | :arrow_down: |
| [...dashboard/components/nativeFilters/FiltersList.tsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0xpc3QudHN4) | `0.00% <ø> (ø)` | |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `60.86% <ø> (ø)` | |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `84.81% <ø> (+1.06%)` | :arrow_up: |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `67.09% <ø> (ø)` | |
| [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `59.75% <100.00%> (-3.28%)` | :arrow_down: |
| ... and [219 more](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=footer). Last update [078a8a1...1097f6e](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #12450: chore: apply capitalization guidelines - iteration 4 (#12343)
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12450:
URL: https://github.com/apache/superset/pull/12450#issuecomment-758726965
please specify all your changes in this PR, include screenshot and test plan, also for all your future PRs. @michael-s-molina 🙏
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12450: chore: apply capitalization guidelines - iteration 4 (#12343)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12450:
URL: https://github.com/apache/superset/pull/12450#issuecomment-758737541
# [Codecov](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=h1) Report
> Merging [#12450](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=desc) (1937724) into [master](https://codecov.io/gh/apache/superset/commit/5504762458e127063e36f5aa149bbdf3f6fc8f80?el=desc) (5504762) will **decrease** coverage by `1.23%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12450 +/- ##
==========================================
- Coverage 64.55% 63.32% -1.24%
==========================================
Files 1018 486 -532
Lines 49787 29970 -19817
Branches 4971 0 -4971
==========================================
- Hits 32141 18978 -13163
+ Misses 17468 10992 -6476
+ Partials 178 0 -178
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.32% <ø> (-0.81%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-6.71%)` | :arrow_down: |
| [superset/databases/schemas.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `93.40% <0.00%> (-6.05%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `86.55% <0.00%> (-5.47%)` | :arrow_down: |
| ... and [542 more](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=footer). Last update [5504762...1937724](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12450: chore: apply capitalization guidelines - iteration 4 (#12343)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12450:
URL: https://github.com/apache/superset/pull/12450#issuecomment-758737541
# [Codecov](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=h1) Report
> Merging [#12450](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=desc) (1937724) into [master](https://codecov.io/gh/apache/superset/commit/5504762458e127063e36f5aa149bbdf3f6fc8f80?el=desc) (5504762) will **decrease** coverage by `0.87%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12450 +/- ##
==========================================
- Coverage 64.55% 63.67% -0.88%
==========================================
Files 1018 486 -532
Lines 49787 29985 -19802
Branches 4971 0 -4971
==========================================
- Hits 32141 19094 -13047
+ Misses 17468 10891 -6577
+ Partials 178 0 -178
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.67% <ø> (-0.46%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-6.71%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [...et-frontend/src/dashboard/components/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZC5qc3g=) | | |
| [...d/src/visualizations/TimeTable/FormattedNumber.jsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL1RpbWVUYWJsZS9Gb3JtYXR0ZWROdW1iZXIuanN4) | | |
| [superset-frontend/src/views/CRUD/types.ts](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdHlwZXMudHM=) | | |
| [...tend/src/dashboard/util/getFilterScopeNodesTree.js](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlTm9kZXNUcmVlLmpz) | | |
| [...set-frontend/src/views/CRUD/welcome/ChartTable.tsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9DaGFydFRhYmxlLnRzeA==) | | |
| ... and [517 more](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=footer). Last update [5504762...1937724](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] adam-stasiak commented on pull request #12450: chore: apply capitalization guidelines - iteration 4 (#12343)
Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on pull request #12450:
URL: https://github.com/apache/superset/pull/12450#issuecomment-758840294
looks good to me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12450: chore: apply capitalization guidelines - iteration 4 (#12343)
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12450:
URL: https://github.com/apache/superset/pull/12450#issuecomment-758737541
# [Codecov](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=h1) Report
> Merging [#12450](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=desc) (1097f6e) into [master](https://codecov.io/gh/apache/superset/commit/078a8a17a1883ace050bc3baa0bd500e300e61b1?el=desc) (078a8a1) will **decrease** coverage by `3.55%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12450 +/- ##
==========================================
- Coverage 66.81% 63.25% -3.56%
==========================================
Files 1015 486 -529
Lines 49544 29912 -19632
Branches 5080 0 -5080
==========================================
- Hits 33102 18921 -14181
+ Misses 16312 10991 -5321
+ Partials 130 0 -130
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.25% <ø> (-0.83%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.31% <0.00%> (-6.28%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| ... and [535 more](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=footer). Last update [078a8a1...1097f6e](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12450: chore: apply capitalization guidelines - iteration 4 (#12343)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12450:
URL: https://github.com/apache/superset/pull/12450#issuecomment-758737541
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12450: chore: apply capitalization guidelines - iteration 4 (#12343)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12450:
URL: https://github.com/apache/superset/pull/12450#issuecomment-758737541
# [Codecov](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=h1) Report
> Merging [#12450](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=desc) (1937724) into [master](https://codecov.io/gh/apache/superset/commit/5504762458e127063e36f5aa149bbdf3f6fc8f80?el=desc) (5504762) will **decrease** coverage by `5.48%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12450 +/- ##
==========================================
- Coverage 64.55% 59.07% -5.49%
==========================================
Files 1018 961 -57
Lines 49787 47005 -2782
Branches 4971 4386 -585
==========================================
- Hits 32141 27767 -4374
- Misses 17468 19238 +1770
+ Partials 178 0 -178
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.95% <100.00%> (+13.75%)` | :arrow_up: |
| javascript | `?` | |
| python | `63.67% <ø> (-0.46%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...hboard/components/nativeFilters/CascadePopover.tsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvQ2FzY2FkZVBvcG92ZXIudHN4) | `10.86% <ø> (-11.78%)` | :arrow_down: |
| [...c/dashboard/components/nativeFilters/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyLnRzeA==) | `48.80% <ø> (-3.69%)` | :arrow_down: |
| [...oard/components/nativeFilters/FilterConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnRm9ybS50c3g=) | `68.00% <ø> (-22.48%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `27.90% <ø> (-38.14%)` | :arrow_down: |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `11.76% <ø> (-72.39%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `50.60% <100.00%> (+39.88%)` | :arrow_up: |
| [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `50.85% <100.00%> (-18.30%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [439 more](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=footer). Last update [5504762...1937724](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12450: chore: apply capitalization guidelines - iteration 4 (#12343)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12450:
URL: https://github.com/apache/superset/pull/12450#issuecomment-758737541
# [Codecov](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=h1) Report
> Merging [#12450](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=desc) (1097f6e) into [master](https://codecov.io/gh/apache/superset/commit/078a8a17a1883ace050bc3baa0bd500e300e61b1?el=desc) (078a8a1) will **decrease** coverage by `4.24%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12450 +/- ##
==========================================
- Coverage 66.81% 62.56% -4.25%
==========================================
Files 1015 1015
Lines 49544 49528 -16
Branches 5080 5080
==========================================
- Hits 33102 30988 -2114
- Misses 16312 18331 +2019
- Partials 130 209 +79
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.75% <50.00%> (ø)` | |
| python | `63.75% <ø> (-0.33%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `10.71% <0.00%> (-39.29%)` | :arrow_down: |
| [...hboard/components/nativeFilters/CascadePopover.tsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvQ2FzY2FkZVBvcG92ZXIudHN4) | `22.64% <ø> (ø)` | |
| [...c/dashboard/components/nativeFilters/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyLnRzeA==) | `52.48% <ø> (-1.04%)` | :arrow_down: |
| [...oard/components/nativeFilters/FilterConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnRm9ybS50c3g=) | `80.35% <ø> (-1.79%)` | :arrow_down: |
| [...dashboard/components/nativeFilters/FiltersList.tsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0xpc3QudHN4) | `0.00% <ø> (ø)` | |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `60.86% <ø> (ø)` | |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `84.81% <ø> (+1.06%)` | :arrow_up: |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `67.09% <ø> (ø)` | |
| [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `59.75% <100.00%> (-3.28%)` | :arrow_down: |
| ... and [221 more](https://codecov.io/gh/apache/superset/pull/12450/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=footer). Last update [078a8a1...1097f6e](https://codecov.io/gh/apache/superset/pull/12450?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #12450: chore: apply capitalization guidelines - iteration 4 (#12343)
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #12450:
URL: https://github.com/apache/superset/pull/12450
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc removed a comment on pull request #12450: chore: apply capitalization guidelines - iteration 4 (#12343)
Posted by GitBox <gi...@apache.org>.
junlincc removed a comment on pull request #12450:
URL: https://github.com/apache/superset/pull/12450#issuecomment-758726965
@steejay @mihir174 since Design will review this PR, to make it easier for them, please give a list of menu items that has changed in the description. @michael-s-molina
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org