You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/09/02 06:19:58 UTC

[GitHub] [flink] JingsongLi opened a new pull request #13301: [FLINK-19121][hive] Avoid accessing HDFS frequently in HiveBulkWriterFactory

JingsongLi opened a new pull request #13301:
URL: https://github.com/apache/flink/pull/13301


   
   ## What is the purpose of the change
   
   In HadoopPathBasedBulkWriter, getSize will invoke `FileSystem.exists` and `FileSystem.getFileStatus`, but it is invoked per record.
   There will be lots of visits to HDFS, may make HDFS pressure too high.
   
   
   ## Brief change log
   
   Creating a new `HiveRollingPolicy`:
   * Getting size of the file is too expensive. See `HiveBulkWriterFactory#create`. We can't check for every element, which will cause great pressure on DFS. Therefore, in this implementation, only check the file size in `shouldRollOnProcessingTime`, which can effectively avoid DFS pressure.
   
   ## Verifying this change
   
   Manually testing.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13301: [FLINK-19121][hive] Avoid accessing HDFS frequently in HiveBulkWriterFactory

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #13301:
URL: https://github.com/apache/flink/pull/13301#issuecomment-685356952


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a5a665a041c0a6c2c017289463e5122f2c8f6282",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a5a665a041c0a6c2c017289463e5122f2c8f6282",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a5a665a041c0a6c2c017289463e5122f2c8f6282 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13301: [FLINK-19121][hive] Avoid accessing HDFS frequently in HiveBulkWriterFactory

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #13301:
URL: https://github.com/apache/flink/pull/13301#issuecomment-685329829

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit a5a665a041c0a6c2c017289463e5122f2c8f6282 (Wed Sep 02 06:22:25 UTC 2020)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.

Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:

- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13301: [FLINK-19121][hive] Avoid accessing HDFS frequently in HiveBulkWriterFactory

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #13301:
URL: https://github.com/apache/flink/pull/13301#issuecomment-685329829

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit a5a665a041c0a6c2c017289463e5122f2c8f6282 (Fri Feb 19 07:28:14 UTC 2021)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13301: [FLINK-19121][hive] Avoid accessing HDFS frequently in HiveBulkWriterFactory

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #13301:
URL: https://github.com/apache/flink/pull/13301#issuecomment-685356952


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a5a665a041c0a6c2c017289463e5122f2c8f6282",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6086",
       "triggerID" : "a5a665a041c0a6c2c017289463e5122f2c8f6282",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a5a665a041c0a6c2c017289463e5122f2c8f6282 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6086) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13301: [FLINK-19121][hive] Avoid accessing HDFS frequently in HiveBulkWriterFactory

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #13301:
URL: https://github.com/apache/flink/pull/13301#issuecomment-685356952


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a5a665a041c0a6c2c017289463e5122f2c8f6282",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6086",
       "triggerID" : "a5a665a041c0a6c2c017289463e5122f2c8f6282",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a5a665a041c0a6c2c017289463e5122f2c8f6282 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6086) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] cyofeiyue commented on pull request #13301: [FLINK-19121][hive] Avoid accessing HDFS frequently in HiveBulkWriterFactory

Posted by GitBox <gi...@apache.org>.

cyofeiyue commented on pull request #13301:
URL: https://github.com/apache/flink/pull/13301#issuecomment-699448154


   nice job，because of it，flink sql write into Hive table performance up up


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] JingsongLi merged pull request #13301: [FLINK-19121][hive] Avoid accessing HDFS frequently in HiveBulkWriterFactory

Posted by GitBox <gi...@apache.org>.

JingsongLi merged pull request #13301:
URL: https://github.com/apache/flink/pull/13301


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org