[GitHub] [superset] ktmud commented on a change in pull request #17177: feat: support disabling domain sharding with a query param

[GitBox <gi...@apache.org>]

ktmud commented on a change in pull request #17177:
URL: https://github.com/apache/superset/pull/17177#discussion_r733933872



##########
File path: superset-frontend/src/utils/hostNamesConfig.js
##########
@@ -34,7 +34,14 @@ function getDomainsConfig() {
   // eslint-disable-next-line camelcase
   initFeatureFlags(bootstrapData?.common?.feature_flags);
   const availableDomains = new Set([window.location.hostname]);
+
+  // don't do domain sharding if a certain query param is set
+  const disableDomainSharding =
+    new URLSearchParams(window.location.search).get('disableDomainSharding') ===
+    '1';

Review comment:
       Why not just return even earlier so you don't even have to parse the `bootstrapData`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org