You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2023/07/05 15:06:00 UTC
[GitHub] [arrow] lidavidm opened a new pull request, #36484: GH-36476: [C++][FlightRPC] Fix uninitialized fields in FlightInfo
lidavidm opened a new pull request, #36484:
URL: https://github.com/apache/arrow/pull/36484
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
Fix CI
### What changes are included in this PR?
Provide initializers for fields
### Are these changes tested?
It's UB so it's hard to have a deterministic test
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #36484: GH-36476: [C++][FlightRPC] Fix uninitialized fields in FlightInfo
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #36484:
URL: https://github.com/apache/arrow/pull/36484#issuecomment-1622001685
@github-actions crossbow submit verify-rc-source-integration-linux-ubuntu-22.04-amd64 verify-rc-source-integration-macos-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36484: GH-36476: [C++][FlightRPC] Fix uninitialized fields in FlightInfo
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36484:
URL: https://github.com/apache/arrow/pull/36484#issuecomment-1622005744
Revision: e81a6267def0fbab7ed4917e6878b908fea4d72e
Submitted crossbow builds: [ursacomputing/crossbow @ actions-c56d80e748](https://github.com/ursacomputing/crossbow/branches/all?query=actions-c56d80e748)
|Task|Status|
|----|------|
|verify-rc-source-integration-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5466163361/jobs/9950680163)|
|verify-rc-source-integration-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5466163624/jobs/9950680568)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm merged pull request #36484: GH-36476: [C++][FlightRPC] Fix uninitialized fields in FlightInfo
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #36484:
URL: https://github.com/apache/arrow/pull/36484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36484: GH-36476: [C++][FlightRPC] Fix uninitialized fields in FlightInfo
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36484:
URL: https://github.com/apache/arrow/pull/36484#issuecomment-1621957219
Revision: e81a6267def0fbab7ed4917e6878b908fea4d72e
Submitted crossbow builds: [ursacomputing/crossbow @ actions-f793ef938e](https://github.com/ursacomputing/crossbow/branches/all?query=actions-f793ef938e)
|Task|Status|
|----|------|
|verify-rc-source-integration-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5465922323/jobs/9950089565)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #36484: GH-36476: [C++][FlightRPC] Fix uninitialized fields in FlightInfo
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #36484:
URL: https://github.com/apache/arrow/pull/36484#issuecomment-1621952424
@github-actions crossbow submit verify-rc-source-integration-linux-almalinux-8-amd64
verify-rc-source-integration-linux-ubuntu-22.04-amd64 verify-rc-source-integration-macos-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #36484: GH-36476: [C++][FlightRPC] Fix uninitialized fields in FlightInfo
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36484:
URL: https://github.com/apache/arrow/pull/36484#issuecomment-1630587031
Conbench analyzed the 6 benchmark runs on commit `5c0cbee4`.
There were 3 benchmark results indicating a performance regression:
- Commit Run on `ursa-thinkcentre-m75q` at [2023-07-08 15:14:58Z](http://conbench.ursa.dev/compare/runs/2541bd241d7d4a52b5c98ac6db532d71...0a8c309ad0d844dd8c338f3cbc073b8a/)
- [params=DecodeArrowNonNull_Dense/1024, source=cpp-micro, suite=parquet-encoding-benchmark](http://conbench.ursa.dev/compare/benchmarks/064a955d6ed474f0800022f80c7d5a74...064a97dd951a775180006f0cd6bbc683)
- [params=DecodeArrow_Dense/65536, source=cpp-micro, suite=parquet-encoding-benchmark](http://conbench.ursa.dev/compare/benchmarks/064a955d7b2a796f8000dc8b31183a83...064a97dda13c7c8c80004b921717f336)
- and 1 more (see the report linked below)
The [full Conbench report](https://github.com/apache/arrow/runs/14941778249) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org