changing revision props (was: SVN log character encoding.)

[Greg Stein <gs...@lyra.org>]

On Thu, Sep 12, 2002 at 12:12:18PM -0500, Ben Collins-Sussman wrote:
>...
> (And this should be easy to do over DAV;  just do the same thing we do
> for setting log messages:  do a CHECKOUT of a baseline into our
> activity, and then PROPPATCH it.)

Actually, the model is a bit different. The CHECKOUT creates a working
baseline, where the PROPPATCH is performed. Later, we execute a MERGE which
checks in that working baseline, creating a new one with the props we
attached.

But in the -r2309 case, we're changing an existing baseline (from a
modelling standpoint). Thus, you want to PROPPATCH directly against a
baseline. So... get the URL to the baseline, but don't do a CHECKOUT on it.
Just PROPPATCH it.

mod_dav_svn will need to be tweaked to allow that, but it shouldn't be a
hard one.

However, I *do* worry about enabling that as a remote operation. What hooks
get run? How is authorization performed? Is logging possible?

Effectively, the operation is lossy -- you lose the previous property value.
Lossy operations via the network just feels shaky to me. I like the implicit
requirement that you have shell access (in order to run svnadmin) to change
any revision properties.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: changing revision props (was: SVN log character encoding.)

[Karl Fogel <kf...@newton.ch.collab.net>]

Greg Stein <gs...@lyra.org> writes:
> However, I *do* worry about enabling that as a remote operation. What hooks
> get run? How is authorization performed? Is logging possible?
> 
> Effectively, the operation is lossy -- you lose the previous property value.
> Lossy operations via the network just feels shaky to me. I like the implicit
> requirement that you have shell access (in order to run svnadmin) to change
> any revision properties.

At least for the specific case of the `svn:log-message' revision
property, I think we really need to allow the client to change it.
Fixing up log messages is very common.  CVS allows it from the client
side, and people use the functionality.  Let's face it, virtually
every SVN site is going to install tweak-log.cgi or something similar,
which effectively means you don't need shell access :-).  Since
everyone's going to do it, we might as well make it easy.

Authorization is done as usual for committers.

The new hooks pre_revision_prop and post_revision_prop are run (or
whatever their names are, you get the idea).

I'm not as bothered by a lossy operation being done over the network,
because this particular property value is not reflected in the working
copy anyway.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org