You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by pq...@apache.org on 2009/11/08 16:15:29 UTC
svn commit: r833883 - /httpd/mod_fcgid/trunk/modules/fcgid/fcgid_bridge.c
Author: pqf
Date: Sun Nov 8 15:15:28 2009
New Revision: 833883
URL: http://svn.apache.org/viewvc?rev=833883&view=rev
Log:
procnode->requests_handled does not increase in some cases
Modified:
httpd/mod_fcgid/trunk/modules/fcgid/fcgid_bridge.c
Modified: httpd/mod_fcgid/trunk/modules/fcgid/fcgid_bridge.c
URL: http://svn.apache.org/viewvc/httpd/mod_fcgid/trunk/modules/fcgid/fcgid_bridge.c?rev=833883&r1=833882&r2=833883&view=diff
==============================================================================
--- httpd/mod_fcgid/trunk/modules/fcgid/fcgid_bridge.c (original)
+++ httpd/mod_fcgid/trunk/modules/fcgid/fcgid_bridge.c Sun Nov 8 15:15:28 2009
@@ -171,6 +171,7 @@
}
proc_close_ipc(&ctx->ipc);
+ ++ctx->procnode->requests_handled;
if (ctx->procnode) {
/* FIXME See BZ #47483 */
@@ -196,7 +197,7 @@
return_procnode(r, ctx->procnode,
1 /* communication error */ );
} else if (ctx->procnode->cmdopts.max_requests_per_process
- && ++ctx->procnode->requests_handled >=
+ && ctx->procnode->requests_handled >=
ctx->procnode->cmdopts.max_requests_per_process) {
ctx->procnode->diewhy = FCGID_DIE_LIFETIME_EXPIRED;
return_procnode(r, ctx->procnode,
@@ -448,12 +449,11 @@
int seen_eos;
/* Stdin header and body */
- /* XXX HACK: I have to read all the request into memory before sending it
+ /* I have to read all the request into memory before sending it
to fastcgi application server, this prevents slow clients from
keeping the server in processing too long.
But sometimes it's not acceptable (think about uploading a large attachment)
- file_bucket is a better choice in this case...
- To do, or not to do, that is the question ^_^
+ Request will be stored in tmp file if the size larger than max_mem_request_len
*/
seen_eos = 0;
do {