You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/10/22 18:34:39 UTC

[GitHub] pnowojski commented on a change in pull request #6893: [FLINK-10638] [table] Fix table scan resolution for temporal join queries

pnowojski commented on a change in pull request #6893: [FLINK-10638] [table] Fix table scan resolution for temporal join queries
URL: https://github.com/apache/flink/pull/6893#discussion_r226966124
 
 

 ##########
 File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala
 ##########
 @@ -804,9 +804,9 @@ abstract class StreamTableEnvironment(
     */
   private[flink] def optimize(relNode: RelNode, updatesAsRetraction: Boolean): RelNode = {
     val convSubQueryPlan = optimizeConvertSubQueries(relNode)
-    val temporalTableJoinPlan = optimizeConvertToTemporalJoin(convSubQueryPlan)
 
 Review comment:
   This was being done before `optimizeConvertTableReferences` because unrolling temporal table functions introduces new plan subtrees that can (and will have) new scan nodes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services