You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by daserge <gi...@git.apache.org> on 2015/06/11 20:19:16 UTC
[GitHub] cordova-ios pull request: CB-8197 Switch to nodejs for ios platfor...
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-ios/pull/146
CB-8197 Switch to nodejs for ios platform scripts
Convert `copy-www-build-step.sh` to nodejs
Adds `glob` module and `bundledDependencies` to `package.json`
[Jira issue](https://issues.apache.org/jira/browse/CB-8197)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-ios CB-8197
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/146.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #146
----
commit 8e8d2710f8b1a7ef9241d39623f76f9672ebe6f6
Author: daserge <da...@yandex.ru>
Date: 2015-06-11T18:13:06Z
CB-8197 Switch to nodejs for ios platform scripts
Convert copy-www-build-step.sh to nodejs
Adds glob module and bundledDependencies to package.json
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-8197 Switch to nodejs for ios platfor...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/146#discussion_r32538324
--- Diff: bin/templates/project/__CLI__.xcodeproj/project.pbxproj ---
@@ -374,7 +374,7 @@
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
- shellScript = "cordova/lib/copy-www-build-step.sh";
+ shellScript = "node cordova/lib/copy-www-build-step.js";
--- End diff --
This change assumes `node` to be in the $PATH for this to work. I'm not familiar with OS X and I'm assuming this assumption does not cause a problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-8197 Switch to nodejs for ios platfor...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/146#discussion_r32742742
--- Diff: bin/templates/project/__CLI__.xcodeproj/project.pbxproj ---
@@ -374,7 +374,7 @@
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
- shellScript = "cordova/lib/copy-www-build-step.sh";
+ shellScript = "node cordova/lib/copy-www-build-step.js";
--- End diff --
Hello @shazron, @nikhilkh,
Thanks for your review.
Regarding node' path - I propose to leave it as is taking into account that stand-alone case is uncommon.
We can address it later in case of issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-8197 Switch to nodejs for ios platfor...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-ios/pull/146#issuecomment-112483772
LGTM. Adding `glob` does increase the size of ios platform considerably. I'm assuming there is no other cheaper way to do this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-8197 Switch to nodejs for ios platfor...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/146
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-8197 Switch to nodejs for ios platfor...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/146#discussion_r32759726
--- Diff: bin/templates/project/__CLI__.xcodeproj/project.pbxproj ---
@@ -374,7 +374,7 @@
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
- shellScript = "cordova/lib/copy-www-build-step.sh";
+ shellScript = "node cordova/lib/copy-www-build-step.js";
--- End diff --
+1 The cli dependent on node, so it makes sense to require it in the path.
Does this affect users who are not using the cli? Probably still not a big deal either way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-8197 Switch to nodejs for ios platfor...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/146#discussion_r32547846
--- Diff: bin/templates/project/__CLI__.xcodeproj/project.pbxproj ---
@@ -374,7 +374,7 @@
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
- shellScript = "cordova/lib/copy-www-build-step.sh";
+ shellScript = "node cordova/lib/copy-www-build-step.js";
--- End diff --
I thought about this earlier when the PR came in and I think its a good assumption since it's a Cordova project and the user is using the CLI. The scenario where a user would take the project from platforms/ios and run it stand-alone is miniscule.
Not sure if this is supported fully but Xcode.app does include node.js under `/Applications/Xcode.app/Contents/Developer/usr/share/xcs/Node/bin/node`
You would dynamically get this path by using `xcode-select --print-path` then appending `/usr/share/xcs/Node/bin/node`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org