[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #4829: refactor: split relation of planner into one part.

[GitBox <gi...@apache.org>]

alamb commented on code in PR #4829:
URL: https://github.com/apache/arrow-datafusion/pull/4829#discussion_r1063608835


##########
datafusion/sql/src/expr/mod.rs:
##########
@@ -66,6 +66,47 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
         }
     }
 
+    /// Generate a relational expression from a SQL expression
+    pub fn sql_to_rex(

Review Comment:
   Minor: I think `expr` is more commonly used in this type of API
   
   ```suggestion
       pub fn sql_to_expr(
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org