[GitHub] [dolphinscheduler] ruanwenjun commented on a change in pull request #8490: [Bug-8110][WorkerServer] kill all running task before worker stop

[GitBox <gi...@apache.org>]

ruanwenjun commented on a change in pull request #8490:
URL: https://github.com/apache/dolphinscheduler/pull/8490#discussion_r811895874



##########
File path: dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/WorkerServer.java
##########
@@ -211,4 +221,22 @@ public void close(String cause) {
     public void stop(String cause) {
         close(cause);
     }
+
+    /**
+     * kill all yarn tasks which are running
+     */
+    public void killAllRunningYarnTasks() {

Review comment:
       Agree with @JinyLeeChina, a better way to solve #8110 might better to find out why the worker go into fake death.
   And what is the `fake death`? I guess in `fake death` the close method will not be executed? If the WorkerServer can close, then it will easy to go to death.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org