You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Fabien COELHO <fa...@coelho.net> on 2007/08/17 07:38:10 UTC
Re: svn commit: r26129 - trunk/subversion/libsvn_subr
> -#define human_timestamp_format_suffix _(" (%a, %d %b %Y)")
> +#define human_timestamp_format_suffix " (%a, %d %b %Y)"
I'm wondering whether I was right to remove this _() for this string
as an "obvious bug", or whether I missed the whole point?
If it is to be reversed, please add clear translation guidelines.
--
Fabien.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r26129 - trunk/subversion/libsvn_subr
Posted by Fabien COELHO <fa...@coelho.net>.
>>> -#define human_timestamp_format_suffix _(" (%a, %d %b %Y)")
>>> +#define human_timestamp_format_suffix " (%a, %d %b %Y)"
>>
>> I'm wondering whether I was right to remove this _() for this string
>> as an "obvious bug", or whether I missed the whole point?
>
> This string was translatable. Please revert r26129.
> In some languages the order of date parts is different than %d %b %Y.
Argh. Done in r26156.
I tried to improve the translation comment slightly so that other
translators may not miss the point as I have.
Browsing through strftime documentation, maybe "%x" (preferred date
representation in locale) could have been an option, although not
abbreviated.
Sorry for the flip-flop.
--
Fabien
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r26129 - trunk/subversion/libsvn_subr
Posted by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
2007-08-17 09:37:47 Fabien COELHO napisał(a):
>
> > -#define human_timestamp_format_suffix _(" (%a, %d %b %Y)")
> > +#define human_timestamp_format_suffix " (%a, %d %b %Y)"
>
> I'm wondering whether I was right to remove this _() for this string
> as an "obvious bug", or whether I missed the whole point?
This string was translatable. Please revert r26129.
In some languages the order of date parts is different than %d %b %Y.
- --
Arfrever Frehtes Taifersar Arahesis
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.6 (GNU/Linux)
iD8DBQFGxe/E/axNJ4Xo/ZERApfIAJ4+7IambJm1VXlDpZH74dzuA5V/0ACgmChl
V/6E+eEIewabfcMYNIVgFeI=
=xaPj
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org