You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/01/05 22:02:09 UTC

[GitHub] gatorsmile commented on issue #23468: [SPARK-26535][SQL] Parse literals as DOUBLE instead of DECIMALS

gatorsmile commented on issue #23468: [SPARK-26535][SQL] Parse literals as DOUBLE instead of DECIMALS
URL: https://github.com/apache/spark/pull/23468#issuecomment-451694598
 
 
   > In Spark 2.x, literal values are parsed as DECIMALs. Many RDBMS, instead, treat them as DOUBLE. Among those, we can name Presto, Hive and MSSQL.
   
   This argument is not enough. For example, Presto even treats `1.2` as Double. See the commit: https://github.com/prestodb/presto/commit/dba2648ddc34875aa8b4f8e32a4dba7ba5920e0d It is still different from the mainstream enterprise database, DB2
   
   I would prefer to documenting our current behavior first. Update our Spark SQL doc? Below is some references, 
   - https://www.ibm.com/support/knowledgecenter/en/SSEPEK_10.0.0/sqlref/src/tpc/db2z_constantsintro.html
   - https://docs.microsoft.com/en-us/sql/t-sql/data-types/constants-transact-sql?view=sql-server-2017
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org