You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Jason Chiang (Created) (JIRA)" <ji...@apache.org> on 2011/10/21 18:02:32 UTC
[jira] [Created] (SHINDIG-1648) Media gadgets does not work on IE8
Media gadgets does not work on IE8
----------------------------------
Key: SHINDIG-1648
URL: https://issues.apache.org/jira/browse/SHINDIG-1648
Project: Shindig
Issue Type: Bug
Components: Javascript
Affects Versions: 3.0.0
Environment: IE Browser
Reporter: Jason Chiang
Both Sample media items gadget and Sample media items with OpenGadget API gadget does not render correctly in IE8.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (SHINDIG-1648) Media gadgets does not work on IE8
Posted by "Paul Lindner (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner closed SHINDIG-1648.
---------------------------------
part of 2.5.0-beta1 release.
> Media gadgets does not work on IE8
> ----------------------------------
>
> Key: SHINDIG-1648
> URL: https://issues.apache.org/jira/browse/SHINDIG-1648
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.5.0-beta1
> Environment: IE Browser
> Reporter: Jason Chiang
> Labels: patch
> Fix For: 2.5.0-beta1
>
>
> Both Sample media items gadget and Sample media items with OpenGadget API gadget does not render correctly in IE8.
> Link to code review, https://reviews.apache.org/r/2527/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1648) Media gadgets does not work on
IE8
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132837#comment-13132837 ]
jiraposter@reviews.apache.org commented on SHINDIG-1648:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2527/#review2751
-----------------------------------------------------------
Ship it!
LGTM
- Dan
On 2011-10-21 16:26:52, Jason Chiang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2527/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-21 16:26:52)
bq.
bq.
bq. Review request for shindig, Ryan Baxter and Dan Dumont.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This patch fix the IE8 rendering issue on both Sample media items gadget and Sample media items with openGadget API gadget.
bq. All changes are on the gadget code.
bq. Link to JIRA, https://issues.apache.org/jira/browse/SHINDIG-1648
bq.
bq.
bq. This addresses bug SHINDIG-1648.
bq. https://issues.apache.org/jira/browse/SHINDIG-1648
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/media-openGadgets/MediaUIOpenGadgets.js 1187403
bq. http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/media-openGadgets/Social.js 1187403
bq. http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/media/MediaUI.js 1187403
bq.
bq. Diff: https://reviews.apache.org/r/2527/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Test done on the sample container testing with both Firefox and IE8
bq.
bq.
bq. Thanks,
bq.
bq. Jason
bq.
bq.
> Media gadgets does not work on IE8
> ----------------------------------
>
> Key: SHINDIG-1648
> URL: https://issues.apache.org/jira/browse/SHINDIG-1648
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 3.0.0
> Environment: IE Browser
> Reporter: Jason Chiang
> Labels: patch
> Fix For: 3.0.0
>
>
> Both Sample media items gadget and Sample media items with OpenGadget API gadget does not render correctly in IE8.
> Link to code review, https://reviews.apache.org/r/2527/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1648) Media gadgets does not work on
IE8
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133069#comment-13133069 ]
jiraposter@reviews.apache.org commented on SHINDIG-1648:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2527/#review2761
-----------------------------------------------------------
Ship it!
Committed revision 1187546.
There seems to be a bunch of duplicate code between the gadgets, maybe you should think about abstracting the comment code out so you dont have to make changes in 2 places.
- Ryan
On 2011-10-21 16:26:52, Jason Chiang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2527/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-21 16:26:52)
bq.
bq.
bq. Review request for shindig, Ryan Baxter and Dan Dumont.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This patch fix the IE8 rendering issue on both Sample media items gadget and Sample media items with openGadget API gadget.
bq. All changes are on the gadget code.
bq. Link to JIRA, https://issues.apache.org/jira/browse/SHINDIG-1648
bq.
bq.
bq. This addresses bug SHINDIG-1648.
bq. https://issues.apache.org/jira/browse/SHINDIG-1648
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/media-openGadgets/MediaUIOpenGadgets.js 1187403
bq. http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/media-openGadgets/Social.js 1187403
bq. http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/media/MediaUI.js 1187403
bq.
bq. Diff: https://reviews.apache.org/r/2527/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Test done on the sample container testing with both Firefox and IE8
bq.
bq.
bq. Thanks,
bq.
bq. Jason
bq.
bq.
> Media gadgets does not work on IE8
> ----------------------------------
>
> Key: SHINDIG-1648
> URL: https://issues.apache.org/jira/browse/SHINDIG-1648
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 3.0.0
> Environment: IE Browser
> Reporter: Jason Chiang
> Labels: patch
> Fix For: 3.0.0
>
>
> Both Sample media items gadget and Sample media items with OpenGadget API gadget does not render correctly in IE8.
> Link to code review, https://reviews.apache.org/r/2527/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1648) Media gadgets does not work on
IE8
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132834#comment-13132834 ]
jiraposter@reviews.apache.org commented on SHINDIG-1648:
--------------------------------------------------------
bq. On 2011-10-21 17:00:43, Dan Dumont wrote:
bq. > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/media-openGadgets/MediaUIOpenGadgets.js, line 120
bq. > <https://reviews.apache.org/r/2527/diff/1/?file=52116#file52116line120>
bq. >
bq. > pixel dimensions instead of percentage?
right, set both the width and height to 100 pixel for the thumbnail image.
bq. On 2011-10-21 17:00:43, Dan Dumont wrote:
bq. > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/media/MediaUI.js, line 142
bq. > <https://reviews.apache.org/r/2527/diff/1/?file=52118#file52118line142>
bq. >
bq. > I would think you still want width:'100%' and height: '100%' here.
bq. >
bq. > That json bag are the attributes you want set on a node... so you'll want <img height="100%" width="100%"... > right?
bq. >
bq. > Or did you mean to change this to pixel dimensions instead of percentage?
see above
- Jason
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2527/#review2748
-----------------------------------------------------------
On 2011-10-21 16:26:52, Jason Chiang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2527/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-21 16:26:52)
bq.
bq.
bq. Review request for shindig, Ryan Baxter and Dan Dumont.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This patch fix the IE8 rendering issue on both Sample media items gadget and Sample media items with openGadget API gadget.
bq. All changes are on the gadget code.
bq. Link to JIRA, https://issues.apache.org/jira/browse/SHINDIG-1648
bq.
bq.
bq. This addresses bug SHINDIG-1648.
bq. https://issues.apache.org/jira/browse/SHINDIG-1648
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/media-openGadgets/MediaUIOpenGadgets.js 1187403
bq. http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/media-openGadgets/Social.js 1187403
bq. http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/media/MediaUI.js 1187403
bq.
bq. Diff: https://reviews.apache.org/r/2527/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Test done on the sample container testing with both Firefox and IE8
bq.
bq.
bq. Thanks,
bq.
bq. Jason
bq.
bq.
> Media gadgets does not work on IE8
> ----------------------------------
>
> Key: SHINDIG-1648
> URL: https://issues.apache.org/jira/browse/SHINDIG-1648
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 3.0.0
> Environment: IE Browser
> Reporter: Jason Chiang
> Labels: patch
> Fix For: 3.0.0
>
>
> Both Sample media items gadget and Sample media items with OpenGadget API gadget does not render correctly in IE8.
> Link to code review, https://reviews.apache.org/r/2527/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1648) Media gadgets does not work on
IE8
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132797#comment-13132797 ]
jiraposter@reviews.apache.org commented on SHINDIG-1648:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2527/
-----------------------------------------------------------
Review request for shindig, Ryan Baxter and Dan Dumont.
Summary
-------
This patch fix the IE8 rendering issue on both Sample media items gadget and Sample media items with openGadget API gadget.
All changes are on the gadget code.
Link to JIRA, https://issues.apache.org/jira/browse/SHINDIG-1648
This addresses bug SHINDIG-1648.
https://issues.apache.org/jira/browse/SHINDIG-1648
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/media-openGadgets/MediaUIOpenGadgets.js 1187403
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/media-openGadgets/Social.js 1187403
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/media/MediaUI.js 1187403
Diff: https://reviews.apache.org/r/2527/diff
Testing
-------
Test done on the sample container testing with both Firefox and IE8
Thanks,
Jason
> Media gadgets does not work on IE8
> ----------------------------------
>
> Key: SHINDIG-1648
> URL: https://issues.apache.org/jira/browse/SHINDIG-1648
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 3.0.0
> Environment: IE Browser
> Reporter: Jason Chiang
>
> Both Sample media items gadget and Sample media items with OpenGadget API gadget does not render correctly in IE8.
> Link to code review, https://reviews.apache.org/r/2527/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1648) Media gadgets does not work on
IE8
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132825#comment-13132825 ]
jiraposter@reviews.apache.org commented on SHINDIG-1648:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2527/#review2748
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/media-openGadgets/MediaUIOpenGadgets.js
<https://reviews.apache.org/r/2527/#comment6188>
pixel dimensions instead of percentage?
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/media/MediaUI.js
<https://reviews.apache.org/r/2527/#comment6187>
I would think you still want width:'100%' and height: '100%' here.
That json bag are the attributes you want set on a node... so you'll want <img height="100%" width="100%"... > right?
Or did you mean to change this to pixel dimensions instead of percentage?
- Dan
On 2011-10-21 16:26:52, Jason Chiang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2527/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-21 16:26:52)
bq.
bq.
bq. Review request for shindig, Ryan Baxter and Dan Dumont.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This patch fix the IE8 rendering issue on both Sample media items gadget and Sample media items with openGadget API gadget.
bq. All changes are on the gadget code.
bq. Link to JIRA, https://issues.apache.org/jira/browse/SHINDIG-1648
bq.
bq.
bq. This addresses bug SHINDIG-1648.
bq. https://issues.apache.org/jira/browse/SHINDIG-1648
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/media-openGadgets/MediaUIOpenGadgets.js 1187403
bq. http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/media-openGadgets/Social.js 1187403
bq. http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/media/MediaUI.js 1187403
bq.
bq. Diff: https://reviews.apache.org/r/2527/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Test done on the sample container testing with both Firefox and IE8
bq.
bq.
bq. Thanks,
bq.
bq. Jason
bq.
bq.
> Media gadgets does not work on IE8
> ----------------------------------
>
> Key: SHINDIG-1648
> URL: https://issues.apache.org/jira/browse/SHINDIG-1648
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 3.0.0
> Environment: IE Browser
> Reporter: Jason Chiang
> Labels: patch
> Fix For: 3.0.0
>
>
> Both Sample media items gadget and Sample media items with OpenGadget API gadget does not render correctly in IE8.
> Link to code review, https://reviews.apache.org/r/2527/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1648) Media gadgets does not work on IE8
Posted by "Jason Chiang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Chiang updated SHINDIG-1648:
----------------------------------
Description:
Both Sample media items gadget and Sample media items with OpenGadget API gadget does not render correctly in IE8.
Link to code review, https://reviews.apache.org/r/2527/
was:Both Sample media items gadget and Sample media items with OpenGadget API gadget does not render correctly in IE8.
> Media gadgets does not work on IE8
> ----------------------------------
>
> Key: SHINDIG-1648
> URL: https://issues.apache.org/jira/browse/SHINDIG-1648
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 3.0.0
> Environment: IE Browser
> Reporter: Jason Chiang
>
> Both Sample media items gadget and Sample media items with OpenGadget API gadget does not render correctly in IE8.
> Link to code review, https://reviews.apache.org/r/2527/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira