You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2018/01/30 00:02:16 UTC
Review Request 65414: Added tests for `Resources.find` on revocable
resources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65414/
-----------------------------------------------------------
Review request for mesos, Anish Gupta and James Peach.
Bugs: MESOS-8506
https://issues.apache.org/jira/browse/MESOS-8506
Repository: mesos
Description
-------
Added tests for `Resources.find` on revocable resources.
Diffs
-----
src/tests/resources_tests.cpp bd328b254eff3815fa2e85d17179cf593cb8a349
Diff: https://reviews.apache.org/r/65414/diff/1/
Testing
-------
Thanks,
Zhitao Li
Re: Review Request 65414: Added tests for `Resources.find` on
revocable resources.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65414/#review196656
-----------------------------------------------------------
Ship it!
Ship It!
- James Peach
On Feb. 1, 2018, 9:50 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65414/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2018, 9:50 p.m.)
>
>
> Review request for mesos, Anish Gupta and James Peach.
>
>
> Bugs: MESOS-8506
> https://issues.apache.org/jira/browse/MESOS-8506
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for `Resources.find` on revocable resources.
>
>
> Diffs
> -----
>
> src/tests/resources_tests.cpp bd328b254eff3815fa2e85d17179cf593cb8a349
>
>
> Diff: https://reviews.apache.org/r/65414/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 65414: Added tests for `Resources.find` on
revocable resources.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65414/
-----------------------------------------------------------
(Updated Feb. 1, 2018, 9:50 p.m.)
Review request for mesos, Anish Gupta and James Peach.
Bugs: MESOS-8506
https://issues.apache.org/jira/browse/MESOS-8506
Repository: mesos
Description
-------
Added tests for `Resources.find` on revocable resources.
Diffs (updated)
-----
src/tests/resources_tests.cpp bd328b254eff3815fa2e85d17179cf593cb8a349
Diff: https://reviews.apache.org/r/65414/diff/2/
Changes: https://reviews.apache.org/r/65414/diff/1-2/
Testing
-------
Thanks,
Zhitao Li
Re: Review Request 65414: Added tests for `Resources.find` on
revocable resources.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65414/#review196552
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/resources_tests.cpp
Lines 2893 (patched)
<https://reviews.apache.org/r/65414/#comment276241>
Rather than just "handles correctly", can you say what correct handling is?
src/tests/resources_tests.cpp
Lines 2904 (patched)
<https://reviews.apache.org/r/65414/#comment276242>
Simplify to
```
EXPECT_SOME_EQ(r1, (r1 + r2).find(r1));
```
src/tests/resources_tests.cpp
Lines 2907 (patched)
<https://reviews.apache.org/r/65414/#comment276243>
Simplify to
```
EXPECT_SOME_EQ(r2, (r1 + r2).find(r2));
```
src/tests/resources_tests.cpp
Lines 2910 (patched)
<https://reviews.apache.org/r/65414/#comment276244>
Simplify to
```
EXPECT_NONE(r1.find(r2));
```
src/tests/resources_tests.cpp
Lines 2913 (patched)
<https://reviews.apache.org/r/65414/#comment276245>
Simplify as above.
- James Peach
On Jan. 30, 2018, 12:02 a.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65414/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2018, 12:02 a.m.)
>
>
> Review request for mesos, Anish Gupta and James Peach.
>
>
> Bugs: MESOS-8506
> https://issues.apache.org/jira/browse/MESOS-8506
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for `Resources.find` on revocable resources.
>
>
> Diffs
> -----
>
> src/tests/resources_tests.cpp bd328b254eff3815fa2e85d17179cf593cb8a349
>
>
> Diff: https://reviews.apache.org/r/65414/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>