You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "appletreeisyellow (via GitHub)" <gi...@apache.org> on 2023/04/13 21:53:22 UTC

[GitHub] [arrow] appletreeisyellow opened a new pull request, #35120: GH-35118: [FlightSQL] Use `int32` to refer to 32-bit integers rather than `int`

appletreeisyellow opened a new pull request, #35120:
URL: https://github.com/apache/arrow/pull/35120

   
   
   
   <!--
   Thanks for opening a pull request!
   If this is your first pull request you can find detailed information on how 
   to contribute here:
     * [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
     * [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
   
   
   If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
   
   Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
   
   Then could you also rename the pull request title in the following format?
   
       GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   In the case of PARQUET issues on JIRA the title also supports:
   
       PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
   
   -->
   
   ### Rationale for this change
   
   The spec is inconsistent -- see details on #35118 
   
   ### What changes are included in this PR?
   
   Use `int32` to refer to 32-bit integers rather than `int`
   
   ### Are these changes tested?
   
   No, only comments are changed
   
   ### Are there any user-facing changes?
   
   This clarifies a small corner case in the document
   
   * Closes: https://github.com/apache/arrow/issues/35118


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot commented on pull request #35120: GH-35118: [FlightSQL] Use `int32` to refer to 32-bit integers rather than `int`

Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35120:
URL: https://github.com/apache/arrow/pull/35120#issuecomment-1512581020

   Benchmark runs are scheduled for baseline = 4328ebac629b2c023b8d83d0329dd791cfa16aa7 and contender = 3ff3cc856f47d76aae53c187789900b468c18a58. 3ff3cc856f47d76aae53c187789900b468c18a58 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b9f91e74fbbb4c9bbdb25ba1665ec4b7...543f1e8e08e546739ba4116e8991d491/)
   [Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/7fca9428103947769eec2cf636f29514...5ffed405aa064a8680144ecfac027e7f/)
   [Finished :arrow_down:0.26% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/2a3626b61c84491a8754b08c6eac0636...b5f4825d656548eb8728063d0543c295/)
   [Finished :arrow_down:0.31% :arrow_up:0.06%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/375b5591bf174310a61cdf7a10af228b...8b45d0a7eb824156ab97284887739633/)
   Buildkite builds:
   [Finished] [`3ff3cc85` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2726)
   [Failed] [`3ff3cc85` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2760)
   [Finished] [`3ff3cc85` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2724)
   [Finished] [`3ff3cc85` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2751)
   [Finished] [`4328ebac` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2725)
   [Failed] [`4328ebac` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2759)
   [Finished] [`4328ebac` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2723)
   [Finished] [`4328ebac` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2750)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb merged pull request #35120: GH-35118: [FlightSQL] Use `int32` to refer to 32-bit integers rather than `int`

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #35120:
URL: https://github.com/apache/arrow/pull/35120


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #35120: GH-35118: [FlightSQL] Use `int32` to refer to 32-bit integers rather than `int`

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35120:
URL: https://github.com/apache/arrow/pull/35120#issuecomment-1507653197

   :warning: GitHub issue #35118 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb commented on pull request #35120: GH-35118: [FlightSQL] Use `int32` to refer to 32-bit integers rather than `int`

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #35120:
URL: https://github.com/apache/arrow/pull/35120#issuecomment-1510378096

   Related PR: https://github.com/apache/arrow/pull/35108


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #35120: GH-35118: [FlightSQL] Use `int32` to refer to 32-bit integers rather than `int`

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35120:
URL: https://github.com/apache/arrow/pull/35120#issuecomment-1507653166

   * Closes: #35118


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb commented on pull request #35120: GH-35118: [FlightSQL] Use `int32` to refer to 32-bit integers rather than `int`

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #35120:
URL: https://github.com/apache/arrow/pull/35120#issuecomment-1510378239

   Thanks again @appletreeisyellow 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org